refactor: simplify StableWSConnection constructor params #822
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mahboubii
requested review from
AnatolyRugalev,
gumuz,
vini-btc and
vishalnarkhede
as code owners
|
Size Change: -2.63 kB (1%) Total Size: 261 kB
|
ferhatelmas
reviewed
Nov 26, 2021
| wsBaseURL: Constructor<ChannelType, CommandType, UserType>['wsBaseURL']; | ||
| device: Constructor<ChannelType, CommandType, UserType>['device']; | ||
| // global from constructor | ||
| client: StreamChat<AttachmentType, ChannelType, CommandType, EventType, MessageType, ReactionType, UserType>; |
ferhatelmas
previously approved these changes
Nov 26, 2021
vini-btc
reviewed
Nov 26, 2021
vishalnarkhede
previously approved these changes
Nov 26, 2021
vini-btc
reviewed
Nov 26, 2021
| client_request_id: reqID, | ||
| }; | ||
| const qs = encodeURIComponent(JSON.stringify(params)); | ||
| const token = this.tokenManager.getToken(); | ||
| return `${this.wsBaseURL}/connect?json=${qs}&api_key=${this.apiKey}&authorization=${token}&stream-auth-type=${this.authType}&X-Stream-Client=${this.userAgent}`; | ||
| const token = this.client.tokenManager.getToken(); |
There was a problem hiding this comment.
do we really use token and user_token and with the same value on this call?
There was a problem hiding this comment.
good catch, could be an old mistake
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CLA
Description of the changes, What, Why and How?
Changelog