Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AND-373] Filter-out unneeded notification updates and add flag to enable/disable #1314

Merged
merged 4 commits into from
Mar 13, 2025

Conversation

liviu-timar
Copy link
Member

@liviu-timar liviu-timar commented Mar 10, 2025

🎯 Goal

Ongoing call notifications are updated when the number of participants changes. We have three cases: no remote participant (shows generic info and icon), 1:1 call (shows the name of the other participant and avatar) and multiple participants (shows Group call text and icon). More info in this PR.

🛠 Implementation details

  • Debounced notification updates caused by participants joining/leaving, when the count falls in the same multiple participants case. Useful for calls with a large number of join/leave events, e.g. livestreams.
  • Checking if the participant count change is still in the > 1 case. If yes, don't update the notification.
  • Update the notification only when the participant count changes from multiple to one or none and vice-versa.
  • Added notificationConfig.enableCallNotificationUpdates flag to disable notification updates in StreamVideoBuilder.

Copy link
Contributor

github-actions bot commented Mar 10, 2025

SDK Size Comparison 📏

SDK Before After Difference Status
stream-video-android-core 11.21 MB 11.21 MB 0.00 MB 🟢
stream-video-android-ui-xml 5.66 MB 5.66 MB 0.00 MB 🟢
stream-video-android-ui-compose 5.83 MB 5.83 MB 0.00 MB 🟢

@liviu-timar liviu-timar marked this pull request as ready for review March 10, 2025 13:02
@liviu-timar liviu-timar requested a review from a team as a code owner March 10, 2025 13:02
@liviu-timar liviu-timar changed the title [AND-373] Improve notification updates [AND-373] Debounce notification updates and add flag to enable/disabel Mar 10, 2025
@liviu-timar liviu-timar changed the title [AND-373] Debounce notification updates and add flag to enable/disabel [AND-373] Debounce notification updates and add flag to enable/disable Mar 10, 2025
@liviu-timar liviu-timar changed the title [AND-373] Debounce notification updates and add flag to enable/disable [AND-373] Filter-out unneeded notification updates and add flag to enable/disable Mar 10, 2025
@aleksandar-apostolov aleksandar-apostolov merged commit 8a7bbff into develop Mar 13, 2025
8 checks passed
@aleksandar-apostolov aleksandar-apostolov deleted the and-373-improve-notification-updates branch March 13, 2025 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants