Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AND-393] Revert builder & ringing call UI component changes #1317

Merged
merged 10 commits into from
Mar 13, 2025
Merged

[AND-393] Revert builder & ringing call UI component changes #1317

merged 10 commits into from
Mar 13, 2025

Conversation

liviu-timar
Copy link
Member

@liviu-timar liviu-timar commented Mar 12, 2025 •
edited
Loading

🎯 Goal

  • Revert removed StreamVideoBuilder params.
  • Revert/add @Deprecated versions of UI composables for ringing calls.
  • Revert & deprecate canSkiPermissionRationale param name typo in StreamCallActivityConfiguration.

@liviu-timar liviu-timar requested a review from a team as a code owner March 12, 2025 15:53
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 12, 2025 •
edited
Loading

SDK Size Comparison 📏

SDK Before After Difference Status
stream-video-android-core 11.21 MB 11.21 MB 0.00 MB 🟢
stream-video-android-ui-xml 5.66 MB 5.66 MB 0.00 MB 🟢
stream-video-android-ui-compose 5.83 MB 5.83 MB 0.00 MB 🟢

@liviu-timar liviu-timar marked this pull request as draft March 13, 2025 07:51
@liviu-timar liviu-timar marked this pull request as ready for review March 13, 2025 09:30
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
59.6% Coverage on New Code (required ≥ 80%)
8.6% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

@aleksandar-apostolov aleksandar-apostolov merged commit 8d6931c into develop Mar 13, 2025
7 of 8 checks passed
@aleksandar-apostolov aleksandar-apostolov deleted the and-393-revert-changes branch March 13, 2025 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aleksandar-apostolov aleksandar-apostolov aleksandar-apostolov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@liviu-timar @aleksandar-apostolov