Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate LobbyView to TrackOptions.enabled #626

Merged
merged 2 commits into from
Apr 2, 2024
Merged

Migrate LobbyView to TrackOptions.enabled #626

merged 2 commits into from
Apr 2, 2024

Conversation

Nash0x7E2
Copy link
Member

@Nash0x7E2 Nash0x7E2 commented Mar 28, 2024

🎯 Goal

This PR addresses the issues outlined in the ticket #617.

🛠 Implementation details

Migrates the StreamLobbyView view implementation to TrackOptions.enabled instead of TrackOptions.provided. The Camera and Microphone on/off state are checked and synced to a new instance of CallConnectOptions before being passed to the active Call object.

Tested on:

  • Android: Pixel 3a API version 32
  • iOS: iPhone 15 Pro Max, iOS 17.4
  • React: Stream's current production demo app

🧪 Testing

  • To be added in a separate PR (testing infra needs to be configured)

☑️Contributor Checklist

General

  • Assigned a person/code owner group (required)
  • Thread with the PR link started in a respective Slack channel (#flutter-team) (required)
  • PR is linked to the GitHub issue it resolves

☑️Reviewer Checklist

  • Sample runs & works
  • UI Changes correct (before & after images)
  • Bugs validated (bugfixes)
  • New feature tested and works
  • All code we touched has new or updated Documentation

@Nash0x7E2 Nash0x7E2 self-assigned this Mar 28, 2024
@Nash0x7E2 Nash0x7E2 marked this pull request as ready for review March 28, 2024 22:39
@Nash0x7E2 Nash0x7E2 requested a review from a team as a code owner March 28, 2024 22:39
@Brazol Brazol merged commit f08f335 into main Apr 2, 2024
5 checks passed
@Brazol Brazol deleted the nash/lobby-mic branch April 2, 2024 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants