fix: deprecate camera management hooks on react native #1711
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliverlaz
reviewed
Mar 5, 2025
| @@ -10,6 +10,8 @@ import { useEffect, useRef } from 'react'; | |||
| /** | |||
| * This hook is meant to be used in Lobby view or equivalent. | |||
| * It will cleanup the media stream on unmount if call is not meant to be joined. | |||
| * | |||
| * @deprecated use `call.camera.enable()` or `call.camera.disable()` instead based on your navigation flow. | |||
| */ | |||
| export const useCallMediaStreamCleanup = () => { | |||
There was a problem hiding this comment.
I think we can even delete this hook, as it doesn't seem to be exported to user-land.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.