Skip to content
This repository was archived by the owner on Sep 20, 2023. It is now read-only.

Fix scroll indicator styles in menus #2697

Merged

Conversation

natanrolnik
Copy link
Contributor

More specifically, in Labels, Milestones, People and Branches view controllers.

Before:

Default scroll indicator

After:

White scroll indicator

More specifically, in Labels, Milestones, People and Branches view controllers
@BasThomas
Copy link
Collaborator

Nice! This might be something we want to fix (by default, at least) in the ContextMenu project?

Sent with GitHawk

@natanrolnik
Copy link
Contributor Author

@BasThomas I thought about it. And although I haven’t looked at it enough, I believe that if the background color of the collection view is set outside of ContextMenu, then it should be “together” with the style. Does it make sense?

Sent with GitHawk

@BasThomas
Copy link
Collaborator

You’re right, I missed that. Sorry!

Sent with GitHawk

@BasThomas
Copy link
Collaborator

Thanks, @natanrolnik!

@BasThomas BasThomas merged commit 572596c into GitHawkApp:master Mar 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants