This repository was archived by the owner on Sep 20, 2023. It is now read-only.
Feature/show issues and pr count #2767
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 4, 2019 13:21
BasThomas
suggested changes
Jun 4, 2019
…d of RepositoryIssuesViewController
BasThomas
approved these changes
Jun 10, 2019
| return NSLocalizedString(newTitle, comment: "") | ||
| } | ||
|
|
||
| func composeLocalizedTitle() -> String { |
There was a problem hiding this comment.
We could combine these two functions, keeping the logic in the function rather than the caller?
To me that seems to make the code a little easier to grasp, and putting all the logic in the function.
// set the title
title = composeLocalizedTitle(using: itemCount)
func composeLocalizedTitle(using itemCount: Int?) -> String {
let newTitle: String
if let itemCount = itemCount, itemCount > 0 {
switch type {
case .issues: newTitle = "Issues (\(itemCount))"
case .pullRequests: newTitle = "Pull Requests (\(itemCount))"
}
} else {
switch type {
case .issues: newTitle = "Issues"
case .pullRequests: newTitle = "Pull Requests"
}
}
return NSLocalizedString(newTitle, comment: "")
}What do you think?
| @@ -157,14 +162,23 @@ EmptyViewDelegate { | |||
|
|
|||
| self.controllers = controllers | |||
| } | |||
|
|
|||
| func buildQueryString(using repo: RepositoryDetails, _ searchString: String) -> String { | |||
| return "repo:\(repo.owner)/\(repo.name) \(searchString) ".lowercased() | |||
There was a problem hiding this comment.
Should there be two spaces ( ) between the name and the string?
|
Merging; we can address the two comments later if we want to. They are no blocker for this awesomeness! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feature is based on this ticket #2718