Ignore _pytest.runner by default #2
Merged
+1
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
February 8, 2019 07:59
This will fix pytest duration calculation. Fixes spulec#286
So that the change doesn't leak across tests
rouge8
reviewed
Feb 8, 2019
|
Cuz of the stack limit coverage hack I was talking about. From what I can tell that limit changes how deep into the stack frames freezegun will look into. If it finds something to ignore, it won't patch/fake time. But that limit change has a comment "just to increase coverage". If you revert my change and remove the tests still pass. So that isn't actually testing anything. Just increasing coverage. But I'm not sure why this change actually prevents the fix from working. But since 99% of the time I'm sure people won't change this undocumented limit, I don't think it matters. |
|
hmmmm okay |
rouge8
approved these changes
Feb 8, 2019
|
If you're curious, take a look at api.py and look at |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will fix pytest duration calculation.
PR is open again source (spulec#288), but there remains an open question on how they want to deal with a hack to increase coverage that's causing the tests to now fail, but the cause is not directly due to this change.