Skip to content

Fix benchmark generator #107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 31, 2025
Merged

Fix benchmark generator #107

merged 1 commit into from
Mar 31, 2025

Conversation

mathiasbynens
Copy link
Member

No description provided.

@mathiasbynens
Copy link
Member Author

As https://github.com/GoogleChromeLabs/jsbi/actions shows, GitHub Actions no longer supports the old Node.js versions we have pinned in this repository, and the build isn’t compatible with more recent Node.js versions. One of the steps towards fixing this is changing the import in the generated benchmark scripts. This patch implements that change and some other changes that were necessary to get the Python script to run.

jakobkummerow
jakobkummerow approved these changes Mar 31, 2025
View reviewed changes
Copy link
Collaborator

@jakobkummerow jakobkummerow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mathiasbynens mathiasbynens merged commit 9c9ff05 into main Mar 31, 2025
4 of 5 checks passed
@mathiasbynens mathiasbynens deleted the update-benchmark-generator branch March 31, 2025 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakobkummerow jakobkummerow jakobkummerow approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mathiasbynens @jakobkummerow