feat: Migrate spanner spring data r2dbc #1971

prash-mi · 2023-06-20T12:41:40Z

feat: Migrate spanner spring data r2dbc

Bumps [junit-bom](https://github.com/junit-team/junit5) from 5.8.0 to 5.8.1. - [Release notes](https://github.com/junit-team/junit5/releases) - [Commits](junit-team/junit5@r5.8.0...r5.8.1) --- updated-dependencies: - dependency-name: org.junit:junit-bom dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

…orm#443) Bumps [spring-boot-starter-parent](https://github.com/spring-projects/spring-boot) from 2.5.4 to 2.5.5. - [Release notes](https://github.com/spring-projects/spring-boot/releases) - [Commits](spring-projects/spring-boot@v2.5.4...v2.5.5) --- updated-dependencies: - dependency-name: org.springframework.boot:spring-boot-starter-parent dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

…atform#441) Bumps `r2dbc.version` from 0.8.5.RELEASE to 0.8.6.RELEASE. Updates `r2dbc-spi` from 0.8.5.RELEASE to 0.8.6.RELEASE - [Release notes](https://github.com/r2dbc/r2dbc-spi/releases) - [Changelog](https://github.com/r2dbc/r2dbc-spi/blob/v0.8.6.RELEASE/CHANGELOG) - [Commits](r2dbc/r2dbc-spi@v0.8.5.RELEASE...v0.8.6.RELEASE) Updates `r2dbc-spi-test` from 0.8.5.RELEASE to 0.8.6.RELEASE - [Release notes](https://github.com/r2dbc/r2dbc-spi/releases) - [Changelog](https://github.com/r2dbc/r2dbc-spi/blob/v0.8.6.RELEASE/CHANGELOG) - [Commits](r2dbc/r2dbc-spi@v0.8.5.RELEASE...v0.8.6.RELEASE) --- updated-dependencies: - dependency-name: io.r2dbc:r2dbc-spi dependency-type: direct:production update-type: version-update:semver-patch - dependency-name: io.r2dbc:r2dbc-spi-test dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bumps [libraries-bom](https://github.com/GoogleCloudPlatform/cloud-opensource-java) from 23.0.0 to 23.1.0. - [Release notes](https://github.com/GoogleCloudPlatform/cloud-opensource-java/releases) - [Changelog](https://github.com/GoogleCloudPlatform/cloud-opensource-java/blob/master/CHANGELOG.md) - [Commits](https://github.com/GoogleCloudPlatform/cloud-opensource-java/commits) --- updated-dependencies: - dependency-name: com.google.cloud:libraries-bom dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bumps [reactor-bom](https://github.com/reactor/reactor) from 2020.0.11 to 2020.0.12. - [Release notes](https://github.com/reactor/reactor/releases) - [Commits](reactor/reactor@2020.0.11...2020.0.12) --- updated-dependencies: - dependency-name: io.projectreactor:reactor-bom dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bumps [spring-data-r2dbc](https://github.com/spring-projects/spring-data-build) from 1.3.5 to 1.3.6. - [Release notes](https://github.com/spring-projects/spring-data-build/releases) - [Commits](https://github.com/spring-projects/spring-data-build/commits) --- updated-dependencies: - dependency-name: org.springframework.data:spring-data-r2dbc dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

… style check. (GoogleCloudPlatform#451) Fix links in CONTRIBUTING to reflect adoc style. Also added a line mentioning google-java-format plugin for reformating.

…orm#453) Bumps [spring-boot-starter-parent](https://github.com/spring-projects/spring-boot) from 2.5.5 to 2.5.6. - [Release notes](https://github.com/spring-projects/spring-boot/releases) - [Commits](spring-projects/spring-boot@v2.5.5...v2.5.6) --- updated-dependencies: - dependency-name: org.springframework.boot:spring-boot-starter-parent dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bumps [libraries-bom](https://github.com/GoogleCloudPlatform/cloud-opensource-java) from 23.1.0 to 24.0.0. - [Release notes](https://github.com/GoogleCloudPlatform/cloud-opensource-java/releases) - [Changelog](https://github.com/GoogleCloudPlatform/cloud-opensource-java/blob/master/CHANGELOG.md) - [Commits](https://github.com/GoogleCloudPlatform/cloud-opensource-java/commits) --- updated-dependencies: - dependency-name: com.google.cloud:libraries-bom dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bumps [checkstyle](https://github.com/checkstyle/checkstyle) from 9.0.1 to 9.1. - [Release notes](https://github.com/checkstyle/checkstyle/releases) - [Commits](checkstyle/checkstyle@checkstyle-9.0.1...checkstyle-9.1) --- updated-dependencies: - dependency-name: com.puppycrawl.tools:checkstyle dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bumps [reactor-bom](https://github.com/reactor/reactor) from 2020.0.12 to 2020.0.13. - [Release notes](https://github.com/reactor/reactor/releases) - [Commits](reactor/reactor@2020.0.12...2020.0.13) --- updated-dependencies: - dependency-name: io.projectreactor:reactor-bom dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

…ot to 2.6.0-RC1

Bumps [spring-data-r2dbc](https://github.com/spring-projects/spring-data-build) from 1.3.6 to 1.4.0. - [Release notes](https://github.com/spring-projects/spring-data-build/releases) - [Commits](https://github.com/spring-projects/spring-data-build/commits) --- updated-dependencies: - dependency-name: org.springframework.data:spring-data-r2dbc dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

…tform#703) This fixes compiling error on mvn test-compile phase. Added TODO comment to check on test functionality later.

…atform#705) temp fix and unit test passing.

… -Dit.pubsub-emulator settings. (GoogleCloudPlatform#708) This is PR brings PubSubMessageChannelBinderEmulatorIntegrationTests to junit 5 to avoid mis-match with the abstract test class it inherit from. This test has been running with all modules's integration tests regardless of the -Dit.pubsub-emulator settings. This is step 1 of GoogleCloudPlatform#707 and should unblock and reveal any further issues on it test for other modules.

Update sample pom to match spring boot 2.6.

Adding Spanner JSON Type support JSON support is present in Client library since 6.12.0 release. This PR intend to add JSON support to our repo. Note that ARRAY support is not included and is intended as a follow-up PR to this. (created issue to track GoogleCloudPlatform#458) The major changes include: - Add a JsonWrapper class. - Add binder and decoder. - Add String to JsonWrapper for read. - Add to r2dbc sample and spring data r2dbc sample - README docs - register JsonWrapper.class as simple type in spring data dialect. - register converters to/from Map in spring data dialect as default converters.

…rm#713) This is a temporarily fix to let datastore basic sample work with spring boot 2.6. circular reference is on class org.springframework.shell.result.ResultHandlerConfig (link to error) Suspect cause: This sample uses spring-shell for cmd line interaction. Spring shell seems to be a project relative slow in updating. We are already on the newest version 2.0.1.RELEASE which has dependencies on spring boot 1.5.8.

Bumps [spring-test](https://github.com/spring-projects/spring-framework) from 5.3.12 to 5.3.13. - [Release notes](https://github.com/spring-projects/spring-framework/releases) - [Commits](spring-projects/spring-framework@v5.3.12...v5.3.13) --- updated-dependencies: - dependency-name: org.springframework:spring-test dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

…orm#461) Bumps [spring-boot-starter-parent](https://github.com/spring-projects/spring-boot) from 2.5.6 to 2.6.0. - [Release notes](https://github.com/spring-projects/spring-boot/releases) - [Commits](spring-projects/spring-boot@v2.5.6...v2.6.0) --- updated-dependencies: - dependency-name: org.springframework.boot:spring-boot-starter-parent dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bumps [mockito-core](https://github.com/mockito/mockito) from 4.0.0 to 4.1.0. - [Release notes](https://github.com/mockito/mockito/releases) - [Commits](mockito/mockito@v4.0.0...v4.1.0) --- updated-dependencies: - dependency-name: org.mockito:mockito-core dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

…CloudPlatform#730) This is step 2 and fixes GoogleCloudPlatform#707 There are 2 fixes in this PR: Let PubSubEmulator extend ParameterResolver to inject the emulator port number into the instance. This is left-over from task 1 upgrading to junit5 test, solves the java.lang.NullPointerException: target error caused by no port number provided. After above change, tests fail due to a recent change in spring-cloud-stream logic. when checking if context already has an ObjectMapper bean, calls getBeansOfType(ObjectMapper.class), which has an internal call to assertBeanFactoryActive() Test setup fails with error: “org.springframework.context.support.GenericApplicationContexthas not been refreshed yet”. Fix by refresh the context. Both fixes are within the test setup.

zhumin8 · 2023-07-05T14:59:55Z

spring-cloud-spanner-spring-data-r2dbc/pom.xml

+  <parent>
+    <artifactId>spring-cloud-gcp</artifactId>
+    <groupId>com.google.cloud</groupId>
+    <version>3.5.4-SNAPSHOT</version><!-- {x-version-update:spring-cloud-gcp:current} -->


Reverting a minor maven upgrade in #1997
also fyi, we released v3.5.4 last week (June 28) and 3.x is on 3.5.5-SNAPSHOT now.
Perhaps this is leading to your CI failures.

Suggested change

<version>3.5.4-SNAPSHOT</version>

<version>3.5.5-SNAPSHOT</version>

Thanks @zhumin8 , this was likely the issue. It got resolved after merging with the upstream and then bumping up the version for these two new modules

…ng-data-r2dbc

meltsufin

A few final polish comments.

meltsufin · 2023-07-06T14:09:46Z

docs/src/main/md/spanner-spring-data-r2dbc.md

@@ -0,0 +1,52 @@
+# Cloud Spanner Spring Data R2DBC


You can omit this file, since all of it is being cleaned up anyway.

sure. removed it.

meltsufin · 2023-07-06T14:12:32Z

spring-cloud-gcp-samples/spring-cloud-spanner-r2dbc-samples/pom.xml

+    <dependency>
+        <groupId>org.springframework.data</groupId>
+        <artifactId>spring-data-r2dbc</artifactId>
+        <version>1.5.13</version>
+      </dependency>
+      <dependency>
+        <groupId>io.r2dbc</groupId>
+        <artifactId>r2dbc-spi</artifactId>
+        <version>0.9.0.RELEASE</version>
+      </dependency>


Aren't these already transitively included via spring-cloud-spanner-spring-data-r2dbc?

Also, I'm surprised we don't have to include spring-boot-starter-data-r2dbc, even though we mention it in the documentation. Are docs incorrect?

yes the transitive dependencies are not required to be declared here. I have removed those.

Also @meltsufin I noticed that other modules are having a starter's module mentioned in the documentation , so on the similar lines I have added a new module spring-cloud-gcp-starter-spanner-r2dbc under starters and have referred it @ spanner-spring-data-r2dbc.adoc . Please let me know if it looks good

The starters are there to integrate with auto-configuration. Since we don't have auto-configuration for this module yet, a starter doesn't make sense.
That being said, we should add auto-configuration in the future. Please add it to the list of tasks.

sure @meltsufin , I have removed the starter's module and have mentioned spring-cloud-spanner-spring-data-r2dbc artifact in the adoc

spring-cloud-gcp-samples/spring-cloud-spanner-r2dbc-samples/pom.xml

spring-cloud-spanner-spring-data-r2dbc/pom.xml

meltsufin

Minor polish.

meltsufin · 2023-07-11T17:12:07Z

spring-cloud-gcp-samples/spring-cloud-spanner-r2dbc-samples/pom.xml

+  <name>Spring Framework on Google Cloud Code Sample - Spanner-r2dbc</name>
+
+  <properties>
+    <sonar.skip>true</sonar.skip>


It came from the original repo, have removed it. Lets see if it changes anything in the sonar report

meltsufin · 2023-07-11T17:13:19Z

spring-cloud-spanner-spring-data-r2dbc/pom.xml

+
+  <properties>
+    <spring-data-r2dbc.version>1.5.13</spring-data-r2dbc.version>
+    <spring-test.version>5.3.28</spring-test.version>


meltsufin · 2023-07-11T17:24:15Z

spring-cloud-spanner-spring-data-r2dbc/pom.xml

+    <dependency>
+      <groupId>org.springframework.data</groupId>
+      <artifactId>spring-data-r2dbc</artifactId>
+      <version>${spring-data-r2dbc.version}</version>


Do you really need this version here? I believe the version will already be provided by spring boot bom we import in the parent pom.xml.

yes, tested. It's getting the version from the BOM. removed it from here

meltsufin · 2023-07-11T17:25:30Z

spring-cloud-spanner-spring-data-r2dbc/pom.xml

+    <dependency>
+      <groupId>com.google.cloud</groupId>
+      <artifactId>cloud-spanner-r2dbc</artifactId>
+      <version>${cloud-spanner-r2dbc.version}</version>


Can we manage this dependency version in the parent pom.xml?

meltsufin

2 more small things

meltsufin · 2023-07-12T13:20:22Z

docs/src/main/asciidoc/spanner-spring-data-r2dbc.adoc

+* Support for Reactive Transactions.
+* Schema and data initialization utilities.
+
+See the https://docs.spring.io/spring-data/r2dbc/docs/1.0.x/reference/html/#reference[Spring Data R2DBC documentation] for more information on how to use Spring Data R2DBC.


Maybe this would be a more durable link:

Suggested change

See the https://docs.spring.io/spring-data/r2dbc/docs/1.0.x/reference/html/#reference[Spring Data R2DBC documentation] for more information on how to use Spring Data R2DBC.

See the https://docs.spring.io/spring-data/r2dbc/docs/current/reference/html/[Spring Data R2DBC documentation] for more information on how to use Spring Data R2DBC.

meltsufin · 2023-07-12T13:22:12Z

pom.xml

@@ -42,6 +42,7 @@
 		<spring-cloud-dependencies.version>2021.0.7</spring-cloud-dependencies.version>
 		<spring-cloud-gcp-dependencies.version>${project.parent.version}</spring-cloud-gcp-dependencies.version>
 		<spring-boot-dependencies.version>2.7.13</spring-boot-dependencies.version>
+		<cloud-spanner-r2dbc.version>1.2.2</cloud-spanner-r2dbc.version>


Where is this used?

it was earlier used by spring-cloud-spanner-spring-data-r2dbc, not it's unused, so I have removed it

#Minor refactor #Minor refactor in the POM #removed spanner r2dbc starter and updated spanner-spring-data-r2dbc.adoc #address review comments - cleanup #add spring-cloud-gcp-starter-spanner-r2dbc #addressed review comments - general refactor #version upgrade

…c' into migrate-spanner-spring-data-r2dbc

sonarqubecloud · 2023-07-20T09:51:57Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

83.3% Coverage
0.0% Duplication

Migrated from: https://github.com/GoogleCloudPlatform/cloud-spanner-r2dbc/tree/main/cloud-spanner-spring-data-r2dbc

dependabot bot and others added 30 commits September 23, 2021 10:08

Update current version to 1.0.0-SNAPSHOT (GoogleCloudPlatform#445)

da7051d

open 1.1.0-SNAPSHOT for development (GoogleCloudPlatform#446)

edde5be

Bump checkstyle from 9.0 to 9.0.1 (GoogleCloudPlatform#448)

4cf03e6

Bump mockito-core from 3.12.4 to 4.0.0 (GoogleCloudPlatform#449)

eb8e5c7

fix link style in adoc file, also mention google-java-format tool for…

431e895

… style check. (GoogleCloudPlatform#451) Fix links in CONTRIBUTING to reflect adoc style. Also added a line mentioning google-java-format plugin for reformating.

update spring cloud versions to 2021.0.0-RC1, which updates Spring Bo…

452e85d

…ot to 2.6.0-RC1

replace Mockito.verifyZeroInteractions with verifyNoMoreInteractions

f5ce09d

add new findById method to SimpleDatastoreRepository

ffa431b

Add new methods to SpannerCompositeKeyProperty

93d7a6b

changes in signatures to reflect super class changes. (GoogleCloudPla…

b87cafe

…tform#703) This fixes compiling error on mvn test-compile phase. Added TODO comment to check on test functionality later.

Bring in brave tests locally to bypass assertj errors. (GoogleCloudPl…

84d0c3e

…atform#705) temp fix and unit test passing.

upgrade spring boot version for samples. (GoogleCloudPlatform#709)

315d601

Update sample pom to match spring boot 2.6.

prash-mi added 2 commits July 5, 2023 12:36

add base dir

7ce5b6c

revert commit

9e10f83

zhumin8 mentioned this pull request Jul 5, 2023

Revert "chore(deps): update dependency maven to v3.9.3 (main)" #1997

Merged

zhumin8 reviewed Jul 5, 2023

View reviewed changes

prash-mi added 3 commits July 6, 2023 11:11

Merge remote-tracking branch 'upstream/3.x' into migrate-spanner-spri…

f550229

…ng-data-r2dbc

version upgrade

ff69852

addressed review comments - general refactor

eca6877

meltsufin requested changes Jul 6, 2023

View reviewed changes

prash-mi added 3 commits July 7, 2023 14:37

add spring-cloud-gcp-starter-spanner-r2dbc

0da35eb

address review comments - cleanup

5030f99

removed spanner r2dbc starter and updated spanner-spring-data-r2dbc.adoc

1f0a697

meltsufin requested changes Jul 11, 2023

View reviewed changes

Minor refactor in the POM

f57d132

meltsufin requested changes Jul 12, 2023

View reviewed changes

Minor refactor

28b0051

meltsufin approved these changes Jul 13, 2023

View reviewed changes

meltsufin added the do not merge label Jul 13, 2023

prash-mi added 2 commits July 20, 2023 15:05

Merge remote-tracking branch 'origin/migrate-spanner-spring-data-r2db…

d7eee9b

…c' into migrate-spanner-spring-data-r2dbc

meltsufin merged commit f9303f0 into GoogleCloudPlatform:3.x Jul 24, 2023

meltsufin added r2dbc and removed do not merge labels Jul 24, 2023

release-please bot mentioned this pull request Jul 24, 2023

chore(3.x): release 3.6.0 #2050

Merged

ddixit14 pushed a commit that referenced this pull request Jul 24, 2023

feat: migrate Cloud Spanner Spring Data R2DBC (#1971)

5c01c0f

Migrated from: https://github.com/GoogleCloudPlatform/cloud-spanner-r2dbc/tree/main/cloud-spanner-spring-data-r2dbc

prash-mi mentioned this pull request Jul 25, 2023

feat(main): Migrate spanner spring data r2dbc #2055

Closed

ddixit14 added the release-please:force-run label Jul 26, 2023

release-please bot removed the release-please:force-run label Jul 26, 2023

This was referenced Jul 26, 2023

feat(main): Migrate spanner spring data r2dbc #2062

Closed

feat(main): Migrate spanner spring data r2dbc #2080

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Migrate spanner spring data r2dbc #1971

feat: Migrate spanner spring data r2dbc #1971

prash-mi commented Jun 20, 2023

zhumin8 Jul 5, 2023

prash-mi Jul 6, 2023

meltsufin left a comment

meltsufin Jul 6, 2023

prash-mi Jul 7, 2023

meltsufin Jul 6, 2023

prash-mi Jul 7, 2023

meltsufin Jul 7, 2023

prash-mi Jul 11, 2023

meltsufin left a comment

meltsufin Jul 11, 2023

prash-mi Jul 12, 2023

meltsufin Jul 11, 2023

prash-mi Jul 12, 2023

meltsufin Jul 11, 2023

prash-mi Jul 12, 2023

meltsufin Jul 11, 2023

prash-mi Jul 12, 2023

meltsufin left a comment

meltsufin Jul 12, 2023

prash-mi Jul 13, 2023

meltsufin Jul 12, 2023

prash-mi Jul 13, 2023

sonarqubecloud bot commented Jul 20, 2023

	<version>3.5.4-SNAPSHOT</version><!-- {x-version-update:spring-cloud-gcp:current} -->
	<version>3.5.5-SNAPSHOT</version><!-- {x-version-update:spring-cloud-gcp:current} -->

	See the https://docs.spring.io/spring-data/r2dbc/docs/1.0.x/reference/html/#reference[Spring Data R2DBC documentation] for more information on how to use Spring Data R2DBC.
	See the https://docs.spring.io/spring-data/r2dbc/docs/current/reference/html/[Spring Data R2DBC documentation] for more information on how to use Spring Data R2DBC.

feat: Migrate spanner spring data r2dbc #1971

feat: Migrate spanner spring data r2dbc #1971

Conversation

prash-mi commented Jun 20, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

meltsufin left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

meltsufin left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

meltsufin left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sonarqubecloud bot commented Jul 20, 2023