Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move bazel code into plugins directory #1707

Merged
merged 8 commits into from
Mar 12, 2019

Conversation

priyawadhwa
Copy link
Contributor

@priyawadhwa priyawadhwa commented Feb 28, 2019

Refactoring to move as much bazel code into the plugins directory as possible, so it should be easier to remove the old local builder later on.

continues work on #1765

@codecov-io
Copy link

codecov-io commented Mar 1, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@b76ff3c). Click here to learn what that means.
The diff coverage is 14.92%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1707   +/-   ##
=========================================
  Coverage          ?   46.07%           
=========================================
  Files             ?      134           
  Lines             ?     6366           
  Branches          ?        0           
=========================================
  Hits              ?     2933           
  Misses            ?     3132           
  Partials          ?      301
Impacted Files Coverage Δ
pkg/skaffold/plugin/builders/bazel/dependencies.go 93.33% <ø> (ø)
pkg/skaffold/build/local/local.go 33.33% <0%> (ø)
pkg/skaffold/plugin/builders/bazel/builder.go 15% <0%> (ø)
pkg/skaffold/build/local/bazel.go 0% <0%> (ø)
pkg/skaffold/plugin/builders/bazel/bazel.go 0% <0%> (ø)
pkg/skaffold/plugin/builders/bazel/local.go 17.54% <17.54%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b76ff3c...69ab402. Read the comment docs.

@priyawadhwa priyawadhwa changed the title Move bazel code into plugins directory [wip] Move bazel code into plugins directory Mar 2, 2019
@priyawadhwa priyawadhwa changed the title [wip] Move bazel code into plugins directory Move bazel code into plugins directory Mar 2, 2019
@priyawadhwa
Copy link
Contributor Author

Let's hold off on merging this until the package structure is confirmed --

@priyawadhwa
Copy link
Contributor Author

CI actually passed (red because of the netlify checks) so I'm gonna go ahead and merge this.

@priyawadhwa priyawadhwa merged commit 4aae6af into GoogleContainerTools:master Mar 12, 2019
@priyawadhwa priyawadhwa deleted the refactor branch March 12, 2019 23:24
priyawadhwa pushed a commit to priyawadhwa/skaffold-1 that referenced this pull request Apr 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants