Design proposal for configurable kubecontext #2384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
corneliusweig
requested review from
balopat,
dgageot,
nkubala,
priyawadhwa and
tejal29
as code owners
Signed-off-by: Cornelius Weig <[email protected]>
Signed-off-by: Cornelius Weig <[email protected]>
balopat
reviewed
Jul 2, 2019
Signed-off-by: Cornelius Weig <[email protected]>
balopat
reviewed
Jul 10, 2019
| <td>3.</td> | ||
| <td><code>skaffold.yaml</code></td> | ||
| <td> | ||
| Json-path <code>deploy.kubeContext</code>. |
There was a problem hiding this comment.
Suggested change
| Json-path <code>deploy.kubeContext</code>. | |
| Json-path <code>[profile.]deploy.kubeContext</code>. |
There was a problem hiding this comment.
My current feeling is that we should have the option also in the main pipeline. Although this may not be the recommended way to use this feature, I have a hunch that this will be requested nevertheless.
There was a problem hiding this comment.
agreed, [profile.] meant to signify main pipeline or optionally in a profile...maybe there is a better way to express that :)
balopat
reviewed
Jul 10, 2019
balopat
reviewed
Jul 10, 2019
balopat
reviewed
Jul 10, 2019
balopat
reviewed
Jul 10, 2019
balopat
reviewed
Jul 10, 2019
Signed-off-by: Cornelius Weig <[email protected]>
Signed-off-by: Cornelius Weig <[email protected]>
corneliusweig
commented
Jul 15, 2019
corneliusweig
commented
Jul 15, 2019
Signed-off-by: Cornelius Weig <[email protected]>
Signed-off-by: Cornelius Weig <[email protected]>
Include error detection for profile activation with kubecontext override. Declare namespace-related configs as out-of-scope. Split global config cases. Signed-off-by: Cornelius Weig <[email protected]>
corneliusweig
commented
Jul 26, 2019
corneliusweig
commented
Jul 26, 2019
This was referenced Jul 26, 2019
Signed-off-by: Cornelius Weig <[email protected]>
corneliusweig
force-pushed
the
w/context
branch
from
75e2023 to
c6096fe
Compare
|
@balopat I have included the latest design decisions into this document. From my side, it's ready to be merged now. |
|
@balopat This looks good to me now. |
nkubala
approved these changes
Aug 15, 2019
Closed
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a design proposal for making the kubecontext configurable. The goal here is to lay out different options with their tradeoffs and come to an agreement what is the best way to proceed. I may have missed better alternatives, so if you find better ones, please leave a comment.
I deliberately only present different options, so that the discussion starts unbiased.