Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove logs before building and testing #3105

Merged
merged 1 commit into from
Oct 21, 2019
Merged

Remove logs before building and testing #3105

merged 1 commit into from
Oct 21, 2019

Conversation

dgageot
Copy link
Contributor

@dgageot dgageot commented Oct 21, 2019

There are enough logs before each individual build or test.

Signed-off-by: David Gageot [email protected]

Before
before

After
after

@dgageot
Remove logs before building and testing
02bd62a 
There are enough logs before each individual build
or test.

Signed-off-by: David Gageot <[email protected]>
@codecov
Copy link

codecov bot commented Oct 21, 2019 •
edited
Loading

Codecov Report

Merging #3105 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted Files Coverage Δ
pkg/skaffold/runner/timings.go 91.83% <ø> (-0.33%) ⬇️

nkubala
nkubala approved these changes Oct 21, 2019
View reviewed changes
Copy link
Contributor

@nkubala nkubala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@nkubala nkubala merged commit cb1844d into GoogleContainerTools:master Oct 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nkubala nkubala nkubala approved these changes

@balopat balopat Awaiting requested review from balopat

@tejal29 tejal29 Awaiting requested review from tejal29

Assignees
No one assigned
Labels
cla: yes size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dgageot @nkubala @googlebot