Output logs in color for parallel builds #5014
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #5014 +/- ##
==========================================
+ Coverage 72.11% 72.17% +0.06%
==========================================
Files 365 365
Lines 12773 12823 +50
==========================================
+ Hits 9211 9255 +44
- Misses 2877 2879 +2
- Partials 685 689 +4
Continue to review full report at Codecov.
|
gsquared94
reviewed
Nov 10, 2020
IsaacPD
added
kokoro:run
|
Verified this locally
|
tejal29
suggested changes
Nov 11, 2020
gsquared94
reviewed
Nov 11, 2020
gsquared94
reviewed
Nov 11, 2020
tejal29
approved these changes
Nov 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When building in parallel, logs would not show up with colors for builders that had colorful logs.
Also Fixes: #4913
Related: #4990
Description
Wrap the output writer that is passed through skaffold with a "colorful writer" struct. This allows detecting when we should enable printing with colors at any point by checking in color.Fprint(f/ln) if it is a colorful writer.
Because the writer is now wrapped in a struct we are no longer passing os.Stdout raw and so when running commands it will be necessary to force enable/disable coloring with flags when appropriate.
User facing changes
Logs that normally show up in color in a non-parallel build are also in color for builds done in parallel.
Before (master):
Parallel build containing a jib maven artifact
Running
skaffold run --mute-logs=allin skaffold/examples/rubyIn /var/.../skaffold/deploy/2020-11-02_18-49-06.log
The logs contain ANSI escape codes which do not represent the actual content intended to be logged.
After:
Parallel build containing a jib maven artifact
Running
skaffold run --mute-logs=allin skaffold/examples/rubyIn /var/.../skaffold/deploy/2020-11-02_18-53-51.log
The only thing logged is the intended output.