Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #5253
Description
For some reason the way that I had generated the statik file in #5157 for the metrics credentials conflicted with the existing method that creats the statik file structure. This resulted in calls to
skaffold schema get
andskaffold credits
returningfile not found
if running skaffold built from master with all the licenses and etc. being built in.In order to fix this I followed similarly to the previous statik generation and moved it into the temp directory that ultimately gets exported to
cmd/skaffold/app/cmd/statik/statik.go
Fortunately this bug has not made it into a release so we can fix this and hopefully no one will notice 😅. If not fixed this would also ultimately affect the build release script since it relies on
skaffold credits
skaffold/deploy/skaffold/Dockerfile
Line 23 in dafb415
User facing changes
skaffold credits
andskaffold schema get
work