-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use runCtx instead of of config.Opts for suggesting suggestions. #5490
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5490 +/- ##
=======================================
Coverage 71.46% 71.46%
=======================================
Files 397 398 +1
Lines 14577 14641 +64
=======================================
+ Hits 10417 10463 +46
- Misses 3389 3402 +13
- Partials 771 776 +5
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
refactor looks good, have a small question
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me :)
Relates to #5485
This is a refactor, to break change in smaller PR for #5485.
When adding deploy error codes #4933, i missed the part where
kubectx
gets called directly. We have that information inrunCtx
. It easier to use the evaluated context there instead of re-writing logic to look upkubeContext
Pros
pkg/skaffold/config
andpkg/skaffold/kubernetes/context
from errors.deploy/errors
package.