Remove warning for an image that’s built and used by fqn #713
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgageot
force-pushed
the
fix-706
branch
3 times, most recently
from
5679c22 to
23abe9a
Compare
dgageot
force-pushed
the
fix-706
branch
11 times, most recently
from
2aab14f to
5300d08
Compare
dlorenc
approved these changes
Jun 25, 2018
pkg/skaffold/deploy/kubectl.go
Outdated
| @@ -35,6 +35,8 @@ import ( | |||
| "gopkg.in/yaml.v2" | |||
| ) | |||
|
|
|||
| var warner Warner = &logrusWarner{} | |||
There was a problem hiding this comment.
Maybe add a comment explaining that this is only used so that we can test warnings?
Image that is built and not used might be an error Signed-off-by: David Gageot <[email protected]>
Fixes GoogleContainerTools#706 Signed-off-by: David Gageot <[email protected]>
Signed-off-by: David Gageot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.