Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

json files will be written using utf-8 encoding #187

Merged
merged 3 commits into from
Apr 27, 2023

Conversation

gachiemchiep
Copy link
Contributor

Hello.
When working with image files that have utf-8 character in filename, this tool will not write json in utf-8 encoding .
So I make this PR.

@jorgenusan jorgenusan self-requested a review April 27, 2023 06:51
@jorgenusan
Copy link
Contributor

Thanks for the contribution!

Just two things:

  1. We just updated the pre-commit.yml to fix the CI/lint error. You can merge it from main to fix that part.
  2. to fix the test, on the following line: https://github.com/Gradiant/pyodi/blob/master/tests/apps/test_coco_merge.py#L87
    add a new parameter ensure_ascii=False.

@gachiemchiep
Copy link
Contributor Author

1. We just updated the `pre-commit.yml` to fix the `CI/lint` error. You can merge it from main to fix that part.

I have merged from main.

2. to fix the test, on the following line: https://github.com/Gradiant/pyodi/blob/master/tests/apps/test_coco_merge.py#L87
   add a new parameter `ensure_ascii=False`.

I have added the parameter as you suggest.

@jorgenusan jorgenusan merged commit 5f947f8 into Gradiant:master Apr 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants