fix: Memory leaks in label components #2
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
- Add cleanup for textEl using useEffect - Memoize event handlers to prevent unnecessary re-renders - Fix dependency arrays in useMemo and useCallback hooks - Optimize canvas element disposal - Add proper cleanup for event listeners Part of memory leak fixes in label components.
- Add cleanup for Rect elements using useEffect in LabelOnPolygon - Add cleanup for Group and Rect elements in LabelOnMask - Implement proper canvas element disposal - Use refs to track and cleanup Konva elements Part of memory leak fixes in label components.
- Add cleanup for Group element in LabelOnKP - Add cleanup for Group and Rect elements in LabelOnVideoBbox - Standardize component interfaces to use consistent prop names - Implement proper canvas element disposal - Use refs to track and cleanup Konva elements Part of memory leak fixes in label components.
devin-ai-integration
bot
changed the title
|
Closing due to inactivity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Memory Leak Fixes in Label Components
This PR addresses memory leaks identified in the Label Studio Frontend components, specifically focusing on proper cleanup of Konva canvas elements and event listeners.
Changes Made
LabelOnBbox Component
LabelOnPolygon Component
LabelOnMask Component
LabelOnKP Component
LabelOnVideoBbox Component
Testing
Impact
These changes should significantly reduce memory leaks by ensuring proper cleanup of:
Link to Devin run: https://preview.devin.ai/devin/27000cb55746455d8d54a7d4659cb197
If you have any feedback, you can leave comments in the PR and I'll address them in the app!