-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create devcontainer.json for developers using codespaces gets a GUI to open it in browser because portforwarding simply not working #1153
base: main
Are you sure you want to change the base?
Conversation
|
Hi, can you add more explanation to this PR? I don't know what port 6080 is for or how it relates to Puter. Also, I don't use devcontainers so I have no context for this. |
Hi @KernelDeimos, Thanks for checking this PR! The reason for adding a GUI in the devcontainer.json is that when opening Codespaces in a browser, I need to access it via puter.localhost:4100. However, this gives an "Invalid Host" error. By using a GUI inside Codespaces, we can open the website directly within the container without needing to manually deal with host resolution issues. Let me know if you need more details! |
More details would be helpful but I'm not sure what details to ask for since I haven't used codespaces. That way I'm thinking about this right now, it seems like it's a tool that you're using and therefore is a separate concern from our repository - i.e. if this belongs here everybody's config for their own IDEs and tools would belong here too which doesn't make a lot of sense. It's possible that we really should have supporting config for codespaces in Puter's repo, but if that's the case you'll need to convince me since I'm not familiar with it. |
Thanks for your feedback! I understand your concern about whether this belongs in the repository. The reason for adding this is to improve the developer experience when using Codespaces with this project. Since Codespaces does not handle host resolution properly (resulting in the "Invalid Host" error when trying to access puter.localhost:4100), adding a GUI inside the devcontainer ensures that developers can access the interface without manual configuration. If Codespaces is not a primary focus of this repo, I understand if this isn't a priority. However, if you think support for Codespaces could be useful for contributors, I'd be happy to refine this PR further to align with the repo's goals. Let me know what you think! |
I decided to try Codespaces out. So far my experience was not great, but I can see the value in it if I am able to get it working. Right now I'm stuck on an issue where Codespaces automatically runs If you can help me get through these issues and I can get codespaces working so that I can also use it myself, then I will merge this. |
@KernelDeimos ( the reason for GUI in codespace is when you open codespace in browser and run puter then you wont be able to open puter.localhost:4100, you will get host resolution issues so that you can open it in browser of codespace via GUI of codespace) you don't need GUI of codespace when you connect to codespace via vs code or any local IDE .( there is no problem when you connect to codespace to local IDE , you can directly open puter.localhost:4100 in your browser ) port forwarding issue only occuring when connected to codespace using browser now create a new codespace with new configuration file i updated and install the node of your choice and run the application and open localhost:6080 and click connect and click play icon in bottom left corner and click web browser and there you can see the preview of puter.localhost:4100 let me know if you face any problem |
No description provided.