Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: add missing :needs_network argument #19239

Merged
merged 1 commit into from
Feb 5, 2025

Conversation

samford
Copy link
Member

@samford samford commented Feb 4, 2025

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

I was recently running brew tests without --online and I noticed that there was still one formulae.brew.sh request. I narrowed it down to a brew desc test, so this adds :needs_network to that test. As expected, brew tests doesn't make any network requests after this change unless --online is used.

I was recently running `brew tests` without `--online` and I noticed
that there was still one formulae.brew.sh request. I narrowed it down
to a `brew desc` test, so this adds `:needs_network` to that test.
As expected, `brew tests` doesn't make any network requests after this
change unless `--online` is used.
@apainintheneck apainintheneck added this pull request to the merge queue Feb 5, 2025
Merged via the queue into master with commit 16c2d92 Feb 5, 2025
28 checks passed
@apainintheneck apainintheneck deleted the add-needs-network-to-desc-test branch February 5, 2025 07:40
@MikeMcQuaid
Copy link
Member

Thanks @samford!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants