Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip homepage audit for www.gnu.org and www.nongnu.org on GitHub runners #19501

Merged
merged 2 commits into from
Mar 16, 2025

Conversation

botantony
Copy link
Contributor

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Related issue: Homebrew/homebrew-core#206757

There are a lot of formulae in the core repository that have www.gnu.org and www.nongnu.org homepages (grep -o -n "www\.gnu\.org" -r . | cut -d : -f 1 | uniq -c | wc -l gives 119 entries). Admins do not want to unblock GitHub infrastructure (https://savannah.nongnu.org/support/index.php?111187), so I think it would be better skip this check on Linux (this audit error doesn't occur on macs). If the homepage has a problem it'll be caught during tests on macOS

@Bo98
Copy link
Member

Bo98 commented Mar 15, 2025

Looks good but I'd make it conditional on ENV["HOMEBREW_GITHUB_HOSTED_RUNNER"] instead of the OS.

@botantony
Copy link
Contributor Author

@Bo98 thanks for the feedback

I'll add ENV["HOMEBREW_GITHUB_HOSTED_RUNNER"] but keep it OS specific. brew audit passes the tests on macOS runners (I assume GNU admins didn't ban them because very few people use macOS in GitHub Actions) so we can keep it

If the homepage has a problem it'll be caught during tests on macOS

@botantony botantony force-pushed the ignore-gnu-homepage branch from dbd7e34 to 615916c Compare March 15, 2025 23:26
@Bo98
Copy link
Member

Bo98 commented Mar 15, 2025

Homebrew-core doesn't use GitHub-hosted macOS runners (except certain dependent tests) so I'm guessing you tried it out in a tap?

@botantony
Copy link
Contributor Author

well, i completely forgot homebrew has their own self-hosted ci runners, guess your idea makes sense

@botantony botantony force-pushed the ignore-gnu-homepage branch from 615916c to da3cb65 Compare March 15, 2025 23:45
@botantony botantony changed the title Skip homepage audit for www.gnu.org and www.nongnu.org on Linux Skip homepage audit for www.gnu.org and www.nongnu.org on GitHub runners Mar 15, 2025
@botantony botantony force-pushed the ignore-gnu-homepage branch from 99e8258 to db130b6 Compare March 16, 2025 00:55
Copy link
Member

@Bo98 Bo98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Bo98 Bo98 added this pull request to the merge queue Mar 16, 2025
Merged via the queue into Homebrew:master with commit 3d8e895 Mar 16, 2025
36 checks passed
@botantony botantony deleted the ignore-gnu-homepage branch March 16, 2025 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants