Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

std_go_args: add -tags flag #19506

Merged
merged 1 commit into from
Mar 17, 2025
Merged

std_go_args: add -tags flag #19506

merged 1 commit into from
Mar 17, 2025

Conversation

botantony
Copy link
Contributor

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example. (no needed)
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

A convenient way to set -tags flag with multiple values in std_go_args

@MikeMcQuaid
Copy link
Member

Thanks @botantony! How many formulae would make use of this?

@botantony
Copy link
Contributor Author

@MikeMcQuaid grep shows that about 57 formulae in core repository have line with -tags

@MikeMcQuaid
Copy link
Member

@MikeMcQuaid grep shows that about 57 formulae in core repository have line with -tags

@botantony Are they using std_go_args too? If so: let's do this!

@botantony
Copy link
Contributor Author

Just checked manually, most of them are Go formulae that use std_go_args

@MikeMcQuaid MikeMcQuaid added this pull request to the merge queue Mar 17, 2025
@MikeMcQuaid
Copy link
Member

Thanks again @botantony!

Merged via the queue into Homebrew:master with commit 2462e40 Mar 17, 2025
36 checks passed
@botantony botantony deleted the go-tags branch March 17, 2025 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants