Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rubocops/cask/stanza_order: Ensure arch and os are adjacent #19507

Merged
merged 1 commit into from
Mar 17, 2025

Conversation

issyl0
Copy link
Member

@issyl0 issyl0 commented Mar 16, 2025

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

- Because Patrick wanted this to be codified.
@issyl0 issyl0 force-pushed the cask-stanzas-arch-os-ordered branch from af49ae9 to 089680c Compare March 16, 2025 21:36
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good when 🟢, thanks!

@issyl0
Copy link
Member Author

issyl0 commented Mar 17, 2025

Heh, the style checks on homebrew/cask run against master which doesn't have this change, leading to these failures because we're only just introducing grouping. How do?

@MikeMcQuaid
Copy link
Member

@issyl0 Seems like you may need to temporarily disable some checks in one place or the other?

Copy link
Member

@p-linnane p-linnane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks @issyl0!

@p-linnane p-linnane enabled auto-merge March 17, 2025 15:05
@p-linnane p-linnane added this pull request to the merge queue Mar 17, 2025
Merged via the queue into master with commit 5705464 Mar 17, 2025
36 checks passed
@p-linnane p-linnane deleted the cask-stanzas-arch-os-ordered branch March 17, 2025 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants