Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

livecheck: update types to allow nested JSON hashes #19509

Merged
merged 1 commit into from
Mar 17, 2025

Conversation

khipp
Copy link
Member

@khipp khipp commented Mar 17, 2025

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

This PR allows the JSON data to use when making a POST request to be nested.

Unblocks: Homebrew/homebrew-cask#205110

Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok but if either of the suggested versions can work instead that'd be preferable ❤️ Thanks!

@khipp khipp force-pushed the fix-livecheck-options-types branch from e96fa48 to d993a8e Compare March 17, 2025 09:21
Copy link
Member

@p-linnane p-linnane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @khipp!

@p-linnane p-linnane added this pull request to the merge queue Mar 17, 2025
Merged via the queue into master with commit a4ba96b Mar 17, 2025
36 checks passed
@p-linnane p-linnane deleted the fix-livecheck-options-types branch March 17, 2025 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants