Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

os/linux/diagnostic: skip error on arm64 when HOMEBREW_ARM64_TESTING is set #19511

Merged
merged 1 commit into from
Mar 17, 2025
Merged

os/linux/diagnostic: skip error on arm64 when HOMEBREW_ARM64_TESTING is set #19511

merged 1 commit into from
Mar 17, 2025

Conversation

carlocab
Copy link
Member

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

This1 will enable us to start testing arm64 bottle builds in
Homebrew/core when this environment variable is set.

Footnotes

  1. Along with some tweaks to the dispatch-build-bottle workflow. ↩

@carlocab
os/linux/diagnostic: skip error on arm64 when `HOMEBREW_ARM64_TESTING…
343eac9 
…` is set

This[^1] will enable us to start testing arm64 bottle builds in
Homebrew/core when this environment variable is set.

[^1]: Along with some tweaks to the `dispatch-build-bottle` workflow.
MikeMcQuaid
MikeMcQuaid approved these changes Mar 17, 2025
View reviewed changes
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, thanks!

@MikeMcQuaid MikeMcQuaid added this pull request to the merge queue Mar 17, 2025
Merged via the queue into master with commit 8588898 Mar 17, 2025
36 checks passed
@MikeMcQuaid MikeMcQuaid deleted the doctor-arm64-linux branch March 17, 2025 13:36
carlocab added a commit to Homebrew/homebrew-portable-ruby that referenced this pull request Mar 17, 2025
@carlocab
workflows/build: set HOMEBREW_ARM64_TESTING
0d4d8e0 
We can simplify things a little here after Homebrew/brew#19511.
@carlocab carlocab mentioned this pull request Mar 17, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MikeMcQuaid MikeMcQuaid MikeMcQuaid approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@carlocab @MikeMcQuaid