Skip to content

rustup: add pointers to $PATH config in caveats, take 2 #220021

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 15, 2025

Conversation

rami3l
Copy link
Contributor

@rami3l rami3l commented Apr 14, 2025

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

Supersedes #219866.

As suggested by @MikeMcQuaid in #219866 (comment), the wording of the previous commit has been changed to explicitly mention the intended interaction between the rust and rustup brew formulae.

@github-actions github-actions bot added the rust Rust use is a significant feature of the PR or issue label Apr 14, 2025
@github-actions github-actions bot added the autosquash Automatically squash pull request commits according to Homebrew style. label Apr 15, 2025
@github-actions github-actions bot removed the autosquash Automatically squash pull request commits according to Homebrew style. label Apr 15, 2025
@rami3l rami3l requested a review from MikeMcQuaid April 15, 2025 01:53
Copy link
Contributor

🤖 An automated task has requested bottles to be published to this PR.

Please do not push to this PR branch before the bottle commits have been pushed, as this results in a state that is difficult to recover from. If you need to resolve a merge conflict, please use a merge commit. Do not force-push to this PR branch.

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Apr 15, 2025
@BrewTestBot BrewTestBot enabled auto-merge April 15, 2025 06:10
@BrewTestBot BrewTestBot added this pull request to the merge queue Apr 15, 2025
Merged via the queue into Homebrew:master with commit f550490 Apr 15, 2025
14 checks passed
@rami3l rami3l deleted the patch-2 branch April 15, 2025 06:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. rust Rust use is a significant feature of the PR or issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants