-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: OPTIC-1778: Unify and prettify icons #7169
base: develop
Are you sure you want to change the base?
Conversation
…+ comment item tooltip fixes
…e try to spread its values
/git merge
|
…udio into fb-optic-1778/icons
@@ -1,7 +1,6 @@ | |||
import { inject, observer } from "mobx-react"; | |||
import React, { useEffect, useRef } from "react"; | |||
import { FaAngleDown, FaChevronDown } from "react-icons/fa"; | |||
import { FF_LOPS_E_10, isFF } from "../../utils/feature-flags"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❤️
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My only comment is regarding icon naming and folder organization:
I am not sure if the naming follows this figma or there are any other source
Regarding the structure with assets I see some icons in categorized folders and other that aren't. Is it following any reasoning?
@nass600
|
we have icons across the different libraries that make up LabelStudio. this PR unifies them to remove duplicates + allows us to standardize them. will also run by design to make sure we update icons to a more modern look