Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: OPTIC-1778: Unify and prettify icons #7169

Open
wants to merge 82 commits into
base: develop
Choose a base branch
from

Conversation

yyassi-heartex
Copy link
Contributor

we have icons across the different libraries that make up LabelStudio. this PR unifies them to remove duplicates + allows us to standardize them. will also run by design to make sure we update icons to a more modern look

yyassi-heartex and others added 29 commits February 28, 2025 07:06
@yyassi-heartex
Copy link
Contributor Author

yyassi-heartex commented Mar 11, 2025

/git merge

Workflow run
Successfully merged: 19 files changed, 258 insertions(+), 67 deletions(-)

@@ -1,7 +1,6 @@
import { inject, observer } from "mobx-react";
import React, { useEffect, useRef } from "react";
import { FaAngleDown, FaChevronDown } from "react-icons/fa";
import { FF_LOPS_E_10, isFF } from "../../utils/feature-flags";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

Copy link
Contributor

@nass600 nass600 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My only comment is regarding icon naming and folder organization:
I am not sure if the naming follows this figma or there are any other source
Regarding the structure with assets I see some icons in categorized folders and other that aren't. Is it following any reasoning?

@bmartel
Copy link
Contributor

bmartel commented Mar 12, 2025

My only comment is regarding icon naming and folder organization: I am not sure if the naming follows this figma or there are any other source Regarding the structure with assets I see some icons in categorized folders and other that aren't. Is it following any reasoning?

@nass600
The only reasoning here is it retained the folder structure of the existing icons when moved over to the UI lib, to cut down on amounts of changes required as the focus was on unification most of all in this ticket. I think it is worth doing though, which we have follow up tickets to address. In the follow up I want to have two things be true:

  1. Standardized icons (organize and name them according to figma, also drop any which should not exist/tweak etc.)
  2. All icons are available in Storybook

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants