feat: DIA-1924: "Import sample data" ability in the Data Import page #7206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for label-studio-docs-new-theme canceled.
|
✅ Deploy Preview for heartex-docs canceled.
|
|
/fm sync |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #7206 +/- ##
========================================
Coverage 77.17% 77.18%
========================================
Files 187 187
Lines 14499 14504 +5
========================================
+ Hits 11190 11195 +5
Misses 3309 3309
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
nick-skriabin
force-pushed
the
fb-dia-1924/sample-imports
branch
from
7958c28 to
866cc83
Compare
…ast messages in favour of modals with increased Sentry reporting (#7167) Co-authored-by: robot-ci-heartex <[email protected]>
… results in ERROR 500 on develop (#7203)
… results in ERROR 500 on develop (#7207)
Co-authored-by: robot-ci-heartex <[email protected]> Co-authored-by: mcanu <[email protected]>
…7209) Co-authored-by: robot-ci-heartex <[email protected]>
nass600
requested changes
Mar 13, 2025
| @@ -126,13 +128,29 @@ export const CreateProject = ({ onClose, redirect = true }) => { | |||
| }), | |||
| [name, description, config], | |||
| ); | |||
| const uploadSample = useCallback( | |||
There was a problem hiding this comment.
I would suggest to adding the interaction with the API to a hook and using it the same way as line 109. Probably the hook should be located in labelstudio/src/hooks
| @@ -30,6 +31,22 @@ export const Inner = () => { | |||
| return refresh(pathname); | |||
| }, [location, history]); | |||
|
|
|||
| const uploadSample = useCallback( | |||
There was a problem hiding this comment.
I would use the same hook stated previously
bmartel
reviewed
Mar 13, 2025
Comment on lines
+6
to
+8
| "dependencies": { | ||
| "@radix-ui/react-select": "^2.1.6" | ||
| }, |
There was a problem hiding this comment.
Suggested change
| "dependencies": { | |
| "@radix-ui/react-select": "^2.1.6" | |
| }, | |
| "dependencies": {}, |
This shouldn't have its own dependencies as it is a monorepo
bmartel
requested changes
Mar 13, 2025
nick-skriabin
force-pushed
the
fb-dia-1924/sample-imports
branch
from
2544ac0 to
b5d8f7a
Compare
|
Sample 1 (images) is not actually importing - looking into it. Sample 2 works. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[x] add sample data import component
[x] add configurable manifest file with sample data
[x] create default manifest file with data hosted on our s3