fix: OPTIC: 1809: Adding option to only update last_activity after a significant difference #7216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ignificant difference
✅ Deploy Preview for heartex-docs canceled.
|
✅ Deploy Preview for label-studio-docs-new-theme canceled.
|
jombooth
reviewed
Mar 12, 2025
| check_interval = getattr(settings, 'USER_LAST_ACTIVITY_CHECK_INTERVAL', None) | ||
| if check_interval: | ||
| if timezone.now() - self.last_activity < check_interval: | ||
| # Don't update last_activity because it's not necessary since it's close enough to the existing last_activity value |
There was a problem hiding this comment.
should we log a message here so we at least have a record somewhere of the real last_activity?
jombooth
reviewed
Mar 12, 2025
| @@ -65,6 +65,12 @@ class UserLastActivityMixin(models.Model): | |||
| last_activity = models.DateTimeField(_('last activity'), default=timezone.now, editable=False) | |||
|
|
|||
| def update_last_activity(self): | |||
| check_interval = getattr(settings, 'USER_LAST_ACTIVITY_CHECK_INTERVAL', None) | |||
There was a problem hiding this comment.
why do we need getattr here?
wesleylima
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…