Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: LEAP-1296: remove FF_LOPS_86 feature flag #7220

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
+2 −20
Open

refactor: LEAP-1296: remove FF_LOPS_86 feature flag #7220

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 2 additions & 15 deletions web/libs/datamanager/src/components/MainView/DataView/Table.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import { useCallback, useMemo } from "react";
import { FaQuestionCircle } from "react-icons/fa";
import { useShortcut } from "../../../sdk/hotkeys";
import { Block, Elem } from "../../../utils/bem";
import { FF_DEV_2536, FF_LOPS_86, FF_OPTIC_2, isFF } from "../../../utils/feature-flags";
import { FF_DEV_2536, FF_OPTIC_2, isFF } from "../../../utils/feature-flags";
import * as CellViews from "../../CellViews";
import { Icon } from "../../Common/Icon/Icon";
import { ImportButton } from "../../Common/SDKButtons";
Expand Down Expand Up @@ -142,20 +142,7 @@ export const DataView = injector(
<Elem name="title" tag="h3">
Failed to sync data
</Elem>
{isFF(FF_LOPS_86) ? (
<>
<Elem name="text">Check your storage settings and resync to import records</Elem>
<Button
onClick={async () => {
window.open("./settings/storage");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we removing the rest of the component tree and the link to settings for any specific reason?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure I understand the question, but here I'm removing only the part that already doesn't appear in UI with the feature flag's state we have at the end of that feature flag's lifecycle (isFF(FF_LOPS_86) === False).

}}
>
Manage Storage
</Button>
</>
) : (
<Elem name="text">Check your storage settings. You may need to recreate this dataset</Elem>
)}
<Elem name="text">Check your storage settings. You may need to recreate this dataset</Elem>
</Block>
);
}
Expand Down
5 changes: 0 additions & 5 deletions web/libs/datamanager/src/utils/feature-flags.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,11 +52,6 @@ export const FF_LOPS_E_10 = "fflag_feat_front_lops_e_10_updated_ux_short";
*/
export const FF_OPTIC_2 = "fflag_feat_optic_2_ensure_draft_saved_short";

/**
* Adding the ability to toggle dataset storage editability.
*/
export const FF_LOPS_86 = "fflag_feat_front_lops_86_datasets_storage_edit_short";

/**
* Self Serve
* @link https://app.launchdarkly.com/default/test/features/fflag_feat_front_leap_482_self_serve_short/
Expand Down
Loading