Skip to content

Bench eventlogged #6190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 25, 2025
Merged

Bench eventlogged #6190

merged 3 commits into from
Apr 25, 2025

Conversation

fmaste
Copy link
Contributor

@fmaste fmaste commented Apr 23, 2025

Description

  • As we now default to GHC9.6 for workbench we can always assume the the RTS supports eventlog (-l) out of the box. Replace passthru.eventlogged with passthru.noGitRev to maximize nix cache hits.

  • Make sure the commit used to enter a shell is the same one used to populate the nomad job nix_installables stanza. Again, use bash, already in the shell, instead of pkgs.gitRev to obtain the reference to maximize nix cache hits.

  • Remove legacy functionality. Fixing a jq error found meta.json no longer includes a "hostname" property.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. These may include:
    • golden tests
    • property tests
    • roundtrip tests
    • integration tests
      See Runnings tests for more details
  • Any changes are noted in the CHANGELOG.md for affected package
  • The version bounds in .cabal files are updated
  • CI passes. See note on CI. The following CI checks are required:
    • Code is linted with hlint. See .github/workflows/check-hlint.yml to get the hlint version
    • Code is formatted with stylish-haskell. See .github/workflows/stylish-haskell.yml to get the stylish-haskell version
    • Code builds on Linux, MacOS and Windows for ghc-8.10.7 and ghc-9.2.7
  • Self-reviewed the diff

Note on CI

If your PR is from a fork, the necessary CI jobs won't trigger automatically for security reasons.
You will need to get someone with write privileges. Please contact IOG node developers to do this
for you.

@fmaste fmaste force-pushed the bench-eventlogged branch from d0c24ba to e925e5f Compare April 23, 2025 17:25
@fmaste fmaste force-pushed the bench-eventlogged branch from e925e5f to ca04671 Compare April 24, 2025 13:07
@fmaste fmaste marked this pull request as ready for review April 24, 2025 13:08
@fmaste fmaste requested review from a team as code owners April 24, 2025 13:08
Copy link
Contributor

@mgmeier mgmeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mgmeier mgmeier added this pull request to the merge queue Apr 25, 2025
Merged via the queue into master with commit 003bfdf Apr 25, 2025
24 checks passed
@mgmeier mgmeier deleted the bench-eventlogged branch April 25, 2025 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants