-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove dependency on arrayvec #152
Conversation
I think the PR description should mention the build changes. I think you are just using rust_cache? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need a minor patch version bump and an updated changelog.
I added a brief description of the CI changes. They were fairly minor. |
I think if we're bumping MSRV we should at least minor bump. Too easy for a patch version to break builds. We might want to make public policy about that. |
You're 100% right. We do need a policy on that because we've been burned by it with our dependencies multiple times |
Would need to bump MSRV to 1.48 because of this addition to Rust. We could possibly make do with an implementation available start in 1.43, but it doesn't seem as clean.
Open to opinions on if the bump to 1.48 is acceptable, or if we should make an attempt at the 1.43 version instead.
CI changes: