Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't remove graphhopper git repo in docker build #44

Conversation

jtbaker
Copy link
Contributor

@jtbaker jtbaker commented Mar 8, 2025

@HarelM this was my oversight in #41. We need to use the git tags later on to determine whether to build the latest tagged image in .github/build-and-upload.sh, so shouldn't rm -rf ./graphhopper/ in build.sh.

https://github.com/IsraelHikingMap/graphhopper-docker-image-push/blob/main/.github/build-and-upload.sh#L6

@jtbaker jtbaker force-pushed the patch/dont-remove-graphhopper-git-repo-in-docker-build branch from 55cd683 to 21c0607 Compare March 8, 2025 14:12
@jtbaker jtbaker force-pushed the patch/dont-remove-graphhopper-git-repo-in-docker-build branch from 21c0607 to c673cc2 Compare March 8, 2025 14:14
@jtbaker jtbaker mentioned this pull request Mar 8, 2025
@HarelM
Copy link
Member

HarelM commented Mar 8, 2025

Thanks for taking care of this! I hope this will push a tagged image automatically.

@HarelM HarelM merged commit ed0f3ae into IsraelHikingMap:main Mar 8, 2025
@jtbaker
Copy link
Contributor Author

jtbaker commented Mar 8, 2025

Thanks for taking care of this! I hope this will push a tagged image automatically.

@HarelM looks like 10.2 build made it onto the dockerhub registry with both platforms successfully. Let me know if you see any issues on your end, since this is the first "prod" release I suppose using this new build system.

@HarelM
Copy link
Member

HarelM commented Mar 8, 2025

Sure, thanks! I'll keep monitoring.
I activated the build manually today instead of waiting for tomorrow to see if this gets uploaded.
If the instructions for 10.2 are incorrect feel free to update the readme as well, I'm still not using this version in my production site...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants