Shell WindowsRegistryKeyValue functionality broken for default key retrieval using trailing "\"

[memcpy-rand-rand-rand]

Code of Conduct

• I agree to follow this project's Code of Conduct

What happened?

In the Windows Registry, there is a notion of a "Default" key under a path, e.g.

The Windows APIs support this by asking for the key with name of empty string, "".

To support this in the WindowsRegistryKeyValue function without needing to supply a separate path and key, the function would look for a trailing \ on the path. If this is present, it would treat the path as asking for the (Default) key under the path before the trailing \.

It looks like during a refactor this functionality was broken.

The fix is relatively simple. Perhaps we need to also add a set of tests for the function in case of future refactor.

Theme

n/a

What OS are you seeing the problem on?

Windows

Which shell are you using?

cmd, powershell

Log output

n/a

[JanDeDobbeleer]

@memcpy-rand-rand-rand this code hasn't changed in a long time and I see this specific logic still in it so I'll have a look

[memcpy-rand-rand-rand]

use of (Default) keys is quite rare, but I have a specific use-case I only just spotted wasn't working :)

I have a local fix. Feel free to assign the bug to me if you like and I'll remind myself of the branching etc process to get a PR done.

[JanDeDobbeleer]

@memcpy-rand-rand-rand I have a fix ready, was rather silly

[memcpy-rand-rand-rand]

Perfect, same as mine. Confirmed working, thanks 👍

[github-actions]

This issue has been automatically locked since there has not been any recent activity (i.e. last half year) after it was closed. It helps our maintainers focus on the active issues.
If you have found a problem that seems similar, please open a discussion first, complete the body with all the details necessary to reproduce, and mention this issue as reference.