Update SwingInteropContainer.placeInteropAbove
when the renderApi changes
#1913
+68
−5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
renderApi
changes, updateSwingInteropContainer.placeInteropAbove
and possibly reposition the interop views accordingly.Fixes https://youtrack.jetbrains.com/issue/CMP-7746/SwingPanels-placed-incorrectly-on-Windows-if-Direct3D-is-unsupported
Testing
Tested manually by making
renderApi
mutable and then puttingin
ComposeSceneMediator.desktop.kt
.Then running the InteropOrder demo and playing with the colored squares (don't forget to also set
compose.interop.blending=true
).Release Notes
Fixes - Desktop
compose.interop.blending=true
completely breaking Swing interop on Windows when Direct3D is unsupported. Note that interop blending is still supported on Windows only if Direct3D is available.