Skip to content

In DesktopTextInputService, ignore call to stopInput() #2032

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 17, 2025

Conversation

m-sasha
Copy link
Member

@m-sasha m-sasha commented Apr 17, 2025

#1974, adds calls of startInput() (no-argument version) and stopInput to DesktopTextInputService.

Unfortunately, DesktopTextInputService was not prepared for this scenario, as it never expected startInput() (the version without arguments) to be called. It would then call PlatformComponent.disableInput() on stopInput(), causing this to be called twice (another time by DesktopTextInputService2).

This PR fixes DesktopTextInputService to ignore stopInput calls unless the correct startInput function was called.

Release Notes

N/A

…en started with `startInput(TextFieldValue, ...)`
@m-sasha m-sasha requested a review from ASalavei April 17, 2025 13:00
@m-sasha m-sasha merged commit 8cb89f5 into jb-main Apr 17, 2025
9 checks passed
@m-sasha m-sasha deleted the m-sasha/ignore-stopInput-if-not-started branch April 17, 2025 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants