Fix virtual keyboard behaviour on mobile browsers in iOS #2033
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MatkovIvan
approved these changes
Apr 17, 2025
| backingElement.focus() | ||
| } | ||
| }, AddEventListenerOptions(once = true)) | ||
| backingElement.click() |
There was a problem hiding this comment.
Will it trigger any security policies in browsers?
| // unfortunately on ios touch devices focus won't happen asynchronously | ||
| // this leads to https://youtrack.jetbrains.com/issue/CMP-8013 | ||
| // which we are circumventing via focusing in a triggered click event | ||
| backingElement.addEventListener("click", { evt -> |
There was a problem hiding this comment.
Is there a situation where our event will be handled by somebody else instead of this callback?
igordmn
reviewed
Apr 17, 2025
| @@ -54,9 +54,16 @@ internal class BackingDomInput( | |||
| } | |||
|
|
|||
| fun focus() { | |||
| window.requestAnimationFrame { | |||
| // we focusing in next frame as a part of fix for https://youtrack.jetbrains.com/issue/CMP-7836/ | |||
There was a problem hiding this comment.
Is "focusing in next frame" still correct comment? I see that we removed window.requestAnimationFrame. Is it now about that we request in a handler that is also in the next frame?
igordmn
approved these changes
Apr 17, 2025
|
We've came up to an agreement that this looks, very, very suspicios, unreliable and kludgy |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://youtrack.jetbrains.com/issue/CMP-8013
Testing
Manual plus
./gradlew testWebRelease Notes
N/A