Skip to content

Move TextInputService start/stop calls inside TextInputSession #2049

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: jb-main
Choose a base branch
from
Open

Move TextInputService start/stop calls inside TextInputSession #2049

wants to merge 2 commits into from
+113 −168

Conversation

ASalavei
Copy link

Due to the incorrect location of TextInputService startInput/stopInput calls, the text input session for keyboard interaction cannot be prevented.

Fixes https://youtrack.jetbrains.com/issue/CMP-7729

Release Notes

Fixes - iOS

  • Fix issue where keyboard would appear after second tap when text input session was intercepted.

@ASalavei ASalavei requested review from m-sasha, igordmn and Schahen April 23, 2025 06:53
@ASalavei ASalavei marked this pull request as ready for review April 23, 2025 06:56
@ASalavei ASalavei requested a review from mazunin-v-jb April 23, 2025 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m-sasha m-sasha Awaiting requested review from m-sasha

@igordmn igordmn Awaiting requested review from igordmn

@Schahen Schahen Awaiting requested review from Schahen

@mazunin-v-jb mazunin-v-jb Awaiting requested review from mazunin-v-jb

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ASalavei