Added distinctObservable() to Delegates
#5406
Open
+36
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kwindie
changed the title
distinctObservable() to DelegatesdistinctObservable() to Delegates
|
@kw-indie please open a YouTrack first (as it is suggested in our contribution guideline), so we can discuss the issue and possible solutions first. |
|
@fzhinkin I was sure this isn't a significant change, so I didn't create an issue. |
|
@kw-indie all functional and behavioral changes, including the introduction of a new API are significant enough to deserve their own dedicated issues. :) |
|
i see. ok, here is the issue KT-76072 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
kotlin.properties.Delegates.distinctObservabledelegate.Delegates.observableis triggered even when the value hasn't changed (set to the same value). This was unintuitive for me, and not mentioned in the docs.It was still achievable with
Delegates.vetoable, but that requires more work for a much needed function like this.I know we can't change
Delegates.observableitself. So, I addeddistinctObservable, which does whatobservableshould have done (imo).YouTrack issue