-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Humoud AlGhanim #2
Open
HAlGhanim
wants to merge
5
commits into
JoinCODED:main
Choose a base branch
from
HAlGhanim:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
a32b4c2
Done with the task but the challenge test needs safe call / optional …
HAlGhanim b28b80f
Changed the line 33 back to what it was originally so it can be fixed…
HAlGhanim 51dc191
Added safe call to challenge test
HAlGhanim 1d60ded
Changed solution for addSecondAuthor to fit new test
HAlGhanim 075d188
Merge branch 'JoinCODED:main' into main
HAlGhanim File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -27,8 +27,12 @@ function createBook( | |
genre: string | ||
): Book { | ||
// write your code here... | ||
|
||
return {} as Book; // replace "{} as Book" with what you see is fit | ||
return { | ||
title: title, | ||
author: author, | ||
publishedYear: publishedYear, | ||
genre: genre, | ||
}; // replace "{} as Book" with what you see is fit | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. A fun thing you can do in JS: if the key and the variable share the same name you can do: return {
title,
author,
publishedYear,
genre
}; |
||
} | ||
|
||
// DO NOT CHANGE THE LINE OF CODE BELOW (you can use it for testing your code) | ||
|
@@ -50,8 +54,7 @@ const book = createBook( | |
*/ | ||
function printBookTitleAndYear(book: Book): string { | ||
// write your code here... | ||
|
||
return ""; // replace empty string with what you see is fit | ||
return `${book.title} ${book["publishedYear"]}`; // replace empty string with what you see is fit | ||
} | ||
|
||
/** | ||
|
@@ -66,7 +69,7 @@ function printBookTitleAndYear(book: Book): string { | |
*/ | ||
function addPageCount(book: Book, pageCount: number): Book { | ||
// write your code here... | ||
|
||
book.pageCount = pageCount; | ||
return book; | ||
} | ||
|
||
|
@@ -88,7 +91,7 @@ function addPageCount(book: Book, pageCount: number): Book { | |
*/ | ||
function addISBN(book: Book, ISBN: string): Book { | ||
// write your code here... | ||
|
||
book.ISBN = ISBN; | ||
return book; | ||
} | ||
|
||
|
@@ -110,7 +113,7 @@ function addISBN(book: Book, ISBN: string): Book { | |
*/ | ||
function updatePublishedYear(book: Book, newYear: number): Book { | ||
// write your code here... | ||
|
||
book.publishedYear = newYear; | ||
return book; | ||
} | ||
|
||
|
@@ -135,8 +138,12 @@ function updatePublishedYear(book: Book, newYear: number): Book { | |
*/ | ||
function addSecondAuthor(book: Book, additionalAuthor: string): Book { | ||
// write your code here... | ||
|
||
return book; | ||
return { | ||
...book, | ||
author: Array.isArray(book.author) | ||
? [...book.author, additionalAuthor] | ||
: [book.author, additionalAuthor], | ||
}; | ||
} | ||
|
||
export { | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ternary operators should only really be used as expressions (where the entire ternary operator will be replaced with a value. They should not have side-effects or be used as a general replacement for if statements.
A better ternary use here would be: