Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Miscellaneous fixes/improvements #20

Merged
merged 12 commits into from
Apr 18, 2020
Merged

Miscellaneous fixes/improvements #20

merged 12 commits into from
Apr 18, 2020

Conversation

colinxs
Copy link
Contributor

@colinxs colinxs commented Apr 14, 2020

As promised @oschulz, here's the PR! Everything should be non-breaking (I didn't break any tests at least). The only "questionable" change is 2a562cf which adds sizehint!/resize! where only the size in the last dimension is specified. Given that this is the only resizeable dimension it seems useful, but perhaps it would make more sense call them something different e.g. sizehintlastdim!/resizelastdim?

@colinxs
Copy link
Contributor Author

colinxs commented Apr 14, 2020

Once this is reviewed/modified/approved I'll make the PR with broadcasting support :)

@codecov-io
Copy link

codecov-io commented Apr 14, 2020

Codecov Report

Merging #20 into master will increase coverage by 0.02%.
The diff coverage is 97.43%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #20      +/-   ##
==========================================
+ Coverage   89.83%   89.85%   +0.02%     
==========================================
  Files           3        3              
  Lines          59       69      +10     
==========================================
+ Hits           53       62       +9     
- Misses          6        7       +1     
Impacted Files Coverage Δ
src/elasticarray.jl 89.39% <97.43%> (+0.10%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 119b7d5...7e8a149. Read the comment docs.

@colinxs
Copy link
Contributor Author

colinxs commented Apr 14, 2020

If you're wondering why I ditched _copyto_impl: the explicit version appeared to generate simpler LLVM code and it matched the style in Base.

@oschulz
Copy link
Collaborator

oschulz commented Apr 14, 2020

If you're wondering why I ditched _copyto_impl

Thanks for the explanation, I actually had wondered about that. :-)

@oschulz oschulz merged commit 48d3ec5 into JuliaArrays:master Apr 18, 2020
@oschulz
Copy link
Collaborator

oschulz commented May 2, 2020

@colinxs , I'll wait for your PR with the broadcasting support before tagging a new release, Ok? Then we can decide whether it'll be v1.1 or v2.0.

@colinxs
Copy link
Contributor Author

colinxs commented May 4, 2020

@oschulz sounds good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants