-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Miscellaneous fixes/improvements #20
Conversation
Once this is reviewed/modified/approved I'll make the PR with broadcasting support :) |
Codecov Report
@@ Coverage Diff @@
## master #20 +/- ##
==========================================
+ Coverage 89.83% 89.85% +0.02%
==========================================
Files 3 3
Lines 59 69 +10
==========================================
+ Hits 53 62 +9
- Misses 6 7 +1
Continue to review full report at Codecov.
|
If you're wondering why I ditched |
Thanks for the explanation, I actually had wondered about that. :-) |
@colinxs , I'll wait for your PR with the broadcasting support before tagging a new release, Ok? Then we can decide whether it'll be v1.1 or v2.0. |
@oschulz sounds good! |
As promised @oschulz, here's the PR! Everything should be non-breaking (I didn't break any tests at least). The only "questionable" change is 2a562cf which adds
sizehint!
/resize!
where only the size in the last dimension is specified. Given that this is the only resizeable dimension it seems useful, but perhaps it would make more sense call them something different e.g.sizehintlastdim!
/resizelastdim
?