Deprecate zeros(inds::UnitRange...) and similar ones
#12
+7
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The problem is that a UnitRange is an AbstractArray, and `zeros([T], A::AbstractArray)` already means something different (create an all-zeros array of element type T and size of A).
|
That's fine, thank you for noticing the conflict and for the patch. Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sadly, I think we need to eliminate these methods. The problem is that a
UnitRangeis anAbstractArray, andzeros([T], A::AbstractArray)already means something different (create an all-zeros array of element typeTand size ofA). So making a 1-dimensional OffsetArray this way is ambiguous. Sorry I didn't notice this conflict earlier.I made them a deprecation rather than an error in case anyone's code is relying on these. But at a certain point we should delete the deprecations.