Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace SDiagonal with LinearAlgebra.Diagonal of SVector #531

Closed
simonbyrne opened this issue Oct 26, 2018 · 0 comments
Closed

Replace SDiagonal with LinearAlgebra.Diagonal of SVector #531

simonbyrne opened this issue Oct 26, 2018 · 0 comments
Milestone
1.0

Comments

@simonbyrne
Copy link
Contributor

Apparently they're distinct because originally Diagonal wasn't parametric (#240 (comment)). Since this has now been fixed, it would be good to unify them.
@c42f c42f mentioned this issue Oct 27, 2018
Closed
18 tasks
simonbyrne added a commit to simonbyrne/StaticArrays.jl that referenced this issue Oct 27, 2018
@simonbyrne
Use LinearAlgebra.Diagonal instead of defining SDiagonal type
61e1234 
Fixes JuliaArrays#531. I've kept SDiagonal as a type alias for compatibility.
@simonbyrne simonbyrne mentioned this issue Oct 27, 2018
Merged
simonbyrne added a commit to simonbyrne/StaticArrays.jl that referenced this issue Oct 27, 2018
@simonbyrne
Use LinearAlgebra.Diagonal instead of defining SDiagonal type
669b0a4 
Fixes JuliaArrays#531. I've kept SDiagonal as a type alias for compatibility.
@c42f c42f added this to the 1.0 milestone Oct 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.0
Development

No branches or pull requests
2 participants
@c42f @simonbyrne