-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix exp
of SMatrix
with large entries #1295
#1296
Conversation
exp
of SMatrix
fails numerically #1295exp
of SMatrix
with large entries #1295
Tests are failing on Julia nightly for unrelated reasons. Appreciate it if you could review the hotfix. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Thanks for the detailed comments!
Someone needs to run the workflows again. |
This is ready to merge. Could someone please release a patch with this hotfix? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Could you just bump the patch version? I'll merge and tag a new release.
Done 👍🏽 |
Fix #1295
Appreciate if you can review this @mikmoore.