Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix exp of SMatrix with large entries #1295 #1296

Merged
merged 3 commits into from
Feb 28, 2025

Conversation

juliohm
Copy link
Contributor

@juliohm juliohm commented Feb 25, 2025

Fix #1295

Appreciate if you can review this @mikmoore.

@juliohm juliohm changed the title Fix [BUG] exp of SMatrix fails numerically #1295 Fix exp of SMatrix with large entries #1295 Feb 25, 2025
@juliohm
Copy link
Contributor Author

juliohm commented Feb 26, 2025

Tests are failing on Julia nightly for unrelated reasons.

Appreciate it if you could review the hotfix.

Copy link

@mikmoore mikmoore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks for the detailed comments!

@juliohm
Copy link
Contributor Author

juliohm commented Feb 26, 2025

Someone needs to run the workflows again.

@juliohm
Copy link
Contributor Author

juliohm commented Feb 26, 2025

This is ready to merge. Could someone please release a patch with this hotfix?

Copy link
Collaborator

@mateuszbaran mateuszbaran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Could you just bump the patch version? I'll merge and tag a new release.

@juliohm
Copy link
Contributor Author

juliohm commented Feb 28, 2025

Done 👍🏽

@mateuszbaran mateuszbaran merged commit 19ecce7 into JuliaArrays:master Feb 28, 2025
19 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] exp of SMatrix fails numerically
3 participants