-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate ImmutableArrays and FixedSizeArrays compatibility interfaces #521
Conversation
People should use the StaticArrays APIs directly. If there's anything useful left here we should fold it into the main API, or move it to other packages where it fits more neatly.
I'm not against this, but we'll need to make extra sure that the transition is smooth. |
Data point: I have no dependency on that code since a long time. |
Deprecating those will help a lot with #18. And I'm not sure it's even being used as is; https://github.com/JuliaGeometry/GeometryTypes.jl/blob/65f4f2a65f353968aa0eaf9ee18a1a23352290c3/src/types.jl#L47 suggests |
1 similar comment
Deprecating those will help a lot with #18. And I'm not sure it's even being used as is; https://github.com/JuliaGeometry/GeometryTypes.jl/blob/65f4f2a65f353968aa0eaf9ee18a1a23352290c3/src/types.jl#L47 suggests |
@SimonDanisch yes I don't want to leave you scrambling! Do your packages depend on it via |
IIRC there was a GeometryTypes PR to move the functionality there? |
Ah yes: JuliaGeometry/GeometryTypes.jl#153. Good timing (thanks @aaronang). See also JuliaGeometry/GeometryTypes.jl#132 and #459 which I didn't see before making this PR :) |
This broke Plots. |
Minor releases are typically breaking. |
Thanks for the info I guess? :-) |
Also, this JuliaLang/METADATA.jl#19050 (comment) |
Sorry for the breakage, the intention was to provide a proper deprecation warning, and indeed this does so on the surface: julia> using StaticArrays.FixedSizeArrays
WARNING: StaticArrays.FixedSizeArrays is deprecatedStaticArrays.FixedSizeArrays is deprecated. Use StaticArrays directly.
in module StaticArrays
julia> Vec(1,2,3)
3-element Vec{3,Int64}:
1
2
3 (botched warning notwithstanding) So now we need to figure out why it broke it, and quickly release a patch update. |
I am working on a patch. The problem is that before this worked:
since the |
Oh I see. |
As briefly mentioned in #503
At this stage, people should use the StaticArrays APIs directly. If there's anything useful left in StaticArrays.FixedSizeArrays we should fold it into the main API, or move it to other packages where it fits more neatly.
CC @andyferris @SimonDanisch
[edit] Closes #459