Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support \ for SVD factorization #613

Merged
merged 1 commit into from
Jun 5, 2019
Merged

Support \ for SVD factorization #613

merged 1 commit into from
Jun 5, 2019

Conversation

timholy
Copy link
Member

@timholy timholy commented Jun 4, 2019

No description provided.

@coveralls
Copy link

coveralls commented Jun 4, 2019

Coverage Status

Coverage increased (+0.02%) to 81.737% when pulling a745996 on teh/solve_svd into b81044a on master.

Copy link
Member

@c42f c42f left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this looks great Tim. Could I bother you to add a complex test case before merging?

@timholy timholy merged commit ebffb69 into master Jun 5, 2019
@timholy timholy deleted the teh/solve_svd branch June 5, 2019 14:44
@timholy
Copy link
Member Author

timholy commented Jun 5, 2019

Seems like time for a new release. While we wait for #532, given that some return types have changed I propose 0.11.

(If there's a good reason to delay a new release, no worries, there's nothing critical about a new release as far as I'm concerned. Just seems like a lot has changed.)

@c42f
Copy link
Member

c42f commented Jun 5, 2019

Agreed, I've just been thinking in the past few days that we should have a new release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants