added eors #24

prakharcode · 2018-07-22T00:49:03Z

@giordano any lights on this error?

julia> a = rand(3,3)
3×3 Array{Float64,2}:
 0.286184  0.497562  0.0348385
 0.233051  0.532657  0.925174 
 0.301579  0.295383  0.814692 

julia> equations_of_origins(a, 2)
2.165203821361782

julia> ERFA.eors(a, 2)
0.9459823155896738

codecov-io · 2018-07-22T00:54:32Z

Codecov Report

Merging #24 into master will increase coverage by 0.2%.
The diff coverage is 100%.

@@            Coverage Diff            @@
##           master      #24     +/-   ##
=========================================
+ Coverage   98.75%   98.95%   +0.2%     
=========================================
  Files           5        5             
  Lines          80       96     +16     
=========================================
+ Hits           79       95     +16     
  Misses          1        1

Impacted Files	Coverage Δ
src/AstroBase.jl	`98.75% <100%> (+0.31%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fadd077...522e4e0. Read the comment docs.

giordano · 2018-07-22T00:58:04Z

There are two issues:

÷ in Julia performs integer division, simply leave / for usual division, just like in the C code
you should know by now what's the main issue 😉

prakharcode · 2018-07-22T01:00:42Z

I tried both / and ÷
Okay, let me have a look again

giordano · 2018-07-22T01:06:12Z

In Julia, ÷ and / do very different things.

In C there isn't a native operator to perform integer division between floating point numbers. Instead, division between integer types is integer division, but that's not the case here (all operands in the eors code are double).

helgee · 2018-07-27T10:08:47Z

src/AstroBase.jl

@@ -115,4 +115,25 @@ function tio_locator(jd1, jd2)
    -47e-6 * t * sec2rad(1)
 end

+"""
+    equations_of_origins(rnpb, s)


equation_of_origins

helgee · 2018-07-27T10:24:52Z

@prakharcode This is a row-major vs. column-major matrix issue. You will see that if you pass the transpose of your matrix to the function the result will be correct.

helgee · 2018-07-27T10:25:47Z

@prakharcode BTW, you could also port the test cases from ERFA so you do not have to come up with your own. See here: https://github.com/liberfa/erfa/blob/master/src/t_erfa_c.c

helgee · 2018-07-27T10:27:22Z

@giordano Now I ruined your lesson because I did not read your reply closely 🙈 Sorry 😜

* added * added gmst06 * added 82 * gmst82 * fixed * coverage * Update AstroBase.jl

* pr00 * rebase * Add doctest * Update AstroBase.jl

helgee · 2018-07-30T07:34:20Z

src/AstroBase.jl

+    zs = -x
+    p = (rnpb[1, 1] * xs) + (rnpb[2, 1] * ys) + (rnpb[3, 1] * zs)
+    q = (rnpb[1, 2] * xs) + (rnpb[2, 2] * ys) + (rnpb[3, 2] * zs)
+    ((p != 0) || (q != 0)) ? s - atan2(q, p) : s


Parens are unnecessary.

atan(q, p) see JuliaLang/julia#27248

helgee · 2018-07-30T07:34:32Z

src/AstroBase.jl

    sec2rad((xpr + (xyls[1] + xypl[1]) / 1e6)), sec2rad(ypr + (xyls[2] + xypl[2]) / 1e6)
 end

+"""
+    equations_of_origins(rnpb, s)


equation_of_origins

helgee · 2018-07-30T07:37:27Z

src/AstroBase.jl

+function equation_of_origins(rnpb, s)
+    x = rnpb[1, 3]
+    ax = x / (1.0 + rnpb[3, 3])
+    xs = 1.0 - (ax * x)


Actually, all parens beyond this point should be removed (except for the function call) 😂 https://en.wikipedia.org/wiki/Order_of_operations#Mnemonics 😜

* added * numat * rebase

helgee · 2018-07-31T05:37:44Z

There were some unrelated changes (deleted lines etc.) but I have fixed them myself.

wip

ce570af

prakharcode changed the title ~~[WIP]~~ [WIP] added eors Jul 22, 2018

wip

7ce47d8

helgee reviewed Jul 27, 2018

View reviewed changes

prakharcode added 2 commits July 28, 2018 05:28

resolved

feb71d8

rebase

e5dd534

prakharcode changed the title ~~[WIP] added eors~~ added eors Jul 28, 2018

prakharcode added 2 commits July 29, 2018 17:15

added gmst00 (JuliaAstro#12)

d7a280b

* added * added gmst06 * added 82 * gmst82 * fixed * coverage * Update AstroBase.jl

pr00 (JuliaAstro#13)

efc7ece

* pr00 * rebase * Add doctest * Update AstroBase.jl

helgee reviewed Jul 30, 2018

View reviewed changes

prakharcode and others added 9 commits July 30, 2018 09:56

added Numat (JuliaAstro#18)

43fcd8a

* added * numat * rebase

fw2m (JuliaAstro#15)

d105b77

wip

9ccc041

wip

dccc716

resolved

8a765bf

corr

7eb913a

fix

47abac1

Update AstroBase.jl

1e664e9

Update AstroBase.jl

522e4e0

helgee merged commit 29064d4 into JuliaAstro:master Jul 31, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

added eors #24

added eors #24

prakharcode commented Jul 22, 2018

codecov-io commented Jul 22, 2018 •

edited

Loading

giordano commented Jul 22, 2018

prakharcode commented Jul 22, 2018

giordano commented Jul 22, 2018 •

edited

Loading

helgee Jul 27, 2018

helgee commented Jul 27, 2018

helgee commented Jul 27, 2018

helgee commented Jul 27, 2018

helgee Jul 30, 2018

helgee Jul 30, 2018

helgee Jul 30, 2018

helgee Jul 30, 2018

helgee commented Jul 31, 2018

added eors #24

added eors #24

Conversation

prakharcode commented Jul 22, 2018

codecov-io commented Jul 22, 2018 • edited Loading

Codecov Report

giordano commented Jul 22, 2018

prakharcode commented Jul 22, 2018

giordano commented Jul 22, 2018 • edited Loading

helgee Jul 27, 2018

Choose a reason for hiding this comment

helgee commented Jul 27, 2018

helgee commented Jul 27, 2018

helgee commented Jul 27, 2018

helgee Jul 30, 2018

Choose a reason for hiding this comment

helgee Jul 30, 2018

Choose a reason for hiding this comment

helgee Jul 30, 2018

Choose a reason for hiding this comment

helgee Jul 30, 2018

Choose a reason for hiding this comment

helgee commented Jul 31, 2018

codecov-io commented Jul 22, 2018 •

edited

Loading

giordano commented Jul 22, 2018 •

edited

Loading