This repository was archived by the owner on Apr 3, 2019. It is now read-only.
Revert "win pipe: race condition on queueing uv_pipe_zero_readfile_th… #40
+1
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…read_proc" This reverts commit dd0702a. See discussion at JuliaLang/libuv@de067bc#commitcomment-14457130
|
This has now passed Julia's |
|
🎉 How often does it freeze before? |
|
More often than that. Usually about 4-6 times in a row could get it to happen. |
|
Lgtm |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…read_proc"
This reverts commit dd0702a.
See discussion at JuliaLang/libuv@de067bc#commitcomment-14457130
I'm testing locally whether this fixes (once merged in julia) JuliaLang/julia#16556. cc @vtjnash the original commit has a pretty weak justification "another similar issue that i assume could happen" so I'm going to guess we can afford to drop this if it fixes matters.