-
Notifications
You must be signed in to change notification settings - Fork 1
Update Codecov CLI version #12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
ba5924b
to
7343dc2
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #12 +/- ##
==========================================
+ Coverage 69.84% 70.31% +0.47%
==========================================
Files 2 2
Lines 63 64 +1
==========================================
+ Hits 44 45 +1
Misses 19 19 ☔ View full report in Codecov by Sentry. |
7343dc2
to
afcd5d3
Compare
Starting with this release token less uploads are possible by enabling this in the organizations Codecov settings, closes #8.
afcd5d3
to
1b04a62
Compare
I don't have a good idea to test tokenless uploads -- the docs seem to suggest that if we enable tokenless upload on the JuliaCI org, then any token will be ignored (so we can't test uploads with a token instead). |
I guess it would be fine to merge this and wait for people to file bugs, as long as we clearly show any failure. |
This is the output of the CLI in case of failure: https://buildkite.com/julialang/julia-coverage-buildkite-plugin/builds/23#01933f3a-aa8b-4a68-b89e-18ca5e901ff4/197-210 but it would not surface up as far as before so you would have to dig into the logs. |
What about detecting failure and generating an annotation a la Also, seeing the |
The docs are not super clear: https://docs.codecov.com/docs/codecov-tokens#uploading-without-a-token I interpret the first point as: if the repo is public and you allow tokenless uploads, then any branch/build (even PRs from forks) can upload. And the second point: PRs from forks can upload tokenless (already previously I think?), just not to the master branch, which doesn't make much sense... To they mean the base branch? |
Should we just merge this so that tokenless upload becomes possible? cc @jpsamaroo |
No description provided.