Skip to content

Update Codecov CLI version #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 3, 2024
Merged

Update Codecov CLI version #12

merged 1 commit into from
Dec 3, 2024

Conversation

fredrikekre
Copy link
Member

No description provided.

Copy link

codecov bot commented Nov 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.31%. Comparing base (e949a20) to head (1b04a62).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #12      +/-   ##
==========================================
+ Coverage   69.84%   70.31%   +0.47%     
==========================================
  Files           2        2              
  Lines          63       64       +1     
==========================================
+ Hits           44       45       +1     
  Misses         19       19              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Starting with this release token less uploads are possible by enabling
this in the organizations Codecov settings, closes #8.
@fredrikekre
Copy link
Member Author

I don't have a good idea to test tokenless uploads -- the docs seem to suggest that if we enable tokenless upload on the JuliaCI org, then any token will be ignored (so we can't test uploads with a token instead).

@maleadt
Copy link
Member

maleadt commented Nov 19, 2024

I guess it would be fine to merge this and wait for people to file bugs, as long as we clearly show any failure.

@fredrikekre
Copy link
Member Author

This is the output of the CLI in case of failure: https://buildkite.com/julialang/julia-coverage-buildkite-plugin/builds/23#01933f3a-aa8b-4a68-b89e-18ca5e901ff4/197-210 but it would not surface up as far as before so you would have to dig into the logs.

@maleadt
Copy link
Member

maleadt commented Nov 19, 2024

What about detecting failure and generating an annotation a la Coverage upload failed; please ensure you have a token configured or tokenless upload is enabled in the Codecov settings for your repo/org?

Also, seeing the Token required because branch is protected there, does that mean you need a token anyway for reporting coverage on the master branch? That seems to defeat most of the purpose of tokenless uploads...

@fredrikekre
Copy link
Member Author

The docs are not super clear: https://docs.codecov.com/docs/codecov-tokens#uploading-without-a-token

I interpret the first point as: if the repo is public and you allow tokenless uploads, then any branch/build (even PRs from forks) can upload.

And the second point: PRs from forks can upload tokenless (already previously I think?), just not to the master branch, which doesn't make much sense... To they mean the base branch?

@maleadt
Copy link
Member

maleadt commented Dec 3, 2024

Should we just merge this so that tokenless upload becomes possible? cc @jpsamaroo

@fredrikekre fredrikekre merged commit fa0cd42 into main Dec 3, 2024
3 checks passed
@fredrikekre fredrikekre deleted the fe/update-cli branch December 3, 2024 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants